Merge pull request #1212 from NatLibFi/fix-notation-data-type-tests

Fix notation data type tests
NatLibFi · Sep 16, 2021 · fbe2be0 · fbe2be0
2 parents c960e09 + 15b1300
commit fbe2be0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/model/ConceptPropertyValueLiteral.php b/model/ConceptPropertyValueLiteral.php
@@ -48,7 +48,7 @@ public function getDatatype(): ?string
             $dtLabel = $graph->resource($datatype)->label($this->clang);
             return $dtLabel->getValue();
         }
-        return "";
+        return null;
     }
 
     public function getType()

diff --git a/tests/ConceptPropertyValueLiteralTest.php b/tests/ConceptPropertyValueLiteralTest.php
@@ -63,7 +63,7 @@ public function testGetLabelThatIsABrokenDate() {
   }
 
   /**
-  * @covers ConceptPropertyValueLiteral::getLabel
+  * @covers ConceptPropertyValueLiteral::getDatatype
   */
   public function testGetLabelForDatatype() {
     $vocab = $this->model->getVocabulary('test');
@@ -74,18 +74,18 @@ public function testGetLabelForDatatype() {
   }
 
   /**
-  * @covers ConceptPropertyValueLiteral::getLabel
+  * @covers ConceptPropertyValueLiteral::getDatatype
   */
   public function testGetNotationDatatypeWithoutLabel() {
     $vocab = $this->model->getVocabulary('test');
     $concepts = $vocab->getConceptInfo('http://www.skosmos.skos/test/ta128', 'en');
     $props = $concepts[0]->getProperties();
     $propvals = $props['skos:notation']->getValues();
-    $this->assertEquals('', $propvals['testnotation']->getDatatype());
+    $this->assertNull($propvals['testnotation']->getDatatype());
   }
 
 /**
- * @covers ConceptPropertyValueLiteral::getLabel
+ * @covers ConceptPropertyValueLiteral::getDatatype
  */
 public function testGetLabelForDatatypeIfNull() {
     $vocab = $this->model->getVocabulary('test');