From 93bce0284eace60348290d6f678a3d119cd9f42a Mon Sep 17 00:00:00 2001 From: Vainonen Date: Tue, 1 Mar 2022 11:13:25 +0200 Subject: [PATCH 1/8] Added sorting of callbacks --- model/PluginRegister.php | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/model/PluginRegister.php b/model/PluginRegister.php index b0583835b..1f2f49393 100644 --- a/model/PluginRegister.php +++ b/model/PluginRegister.php @@ -130,18 +130,28 @@ public function getTemplates($names=null) { } /** - * Returns an array of javascript function names to call when loading pages + * Returns a sorted array of javascript function names to call when loading pages + * in order configured with skosmos:vocabularyPlugins * @return array */ public function getCallbacks() { $ret = array(); + $sortedCallbacks = array(); + $order = array(); + foreach ($this->requestedPlugins as $index => $value) { + $order[$value] = $index; + } $plugins = $this->filterPluginsByName('callback', $this->requestedPlugins); foreach ($plugins as $callbacks) { foreach ($callbacks as $callback) { $split = explode('/', $callback); - $ret[] = $split[2]; + $sortedCallbacks[$split[1]] = $split[2]; } } + $sortedCallbacks = array_replace($order, $sortedCallbacks); + foreach ($sortedCallbacks as $callback) { + $ret[] = $callback; + } return $ret; } From ad6aa491ac4930801cc8777e0bdb635406200317 Mon Sep 17 00:00:00 2001 From: Joeli Takala Date: Wed, 2 Mar 2022 09:05:45 +0200 Subject: [PATCH 2/8] Added the possibility to define parameter plugins outside of the ordered plugin list --- model/VocabularyConfig.php | 8 +++++++- tests/testconfig.ttl | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/model/VocabularyConfig.php b/model/VocabularyConfig.php index e33dc3249..32c6111a8 100644 --- a/model/VocabularyConfig.php +++ b/model/VocabularyConfig.php @@ -33,7 +33,6 @@ public function __construct($resource, $globalPlugins=array()) { $this->resource = $resource; $this->globalPlugins = $globalPlugins; - $this->setParameterizedPlugins(); $this->setPropertyLabelOverrides(); $pluginArray = $this->getPluginArray(); $this->pluginRegister = new PluginRegister($pluginArray); @@ -45,6 +44,7 @@ public function __construct($resource, $globalPlugins=array()) */ public function getPluginArray() : array { + $this->setParameterizedPlugins(); $pluginArray = array(); $vocabularyPlugins = $this->resource->getResource('skosmos:vocabularyPlugins'); if (!$vocabularyPlugins instanceof EasyRdf\Collection) { @@ -62,6 +62,12 @@ public function getPluginArray() : array } $pluginArray = array_merge($pluginArray, $this->globalPlugins); + $paramPlugins = $this->resource->allResources('skosmos:useParamPlugin'); + if ($paramPlugins) { + foreach ($paramPlugins as $plugin) { + $pluginArray[] = $plugin->getLiteral('skosmos:usePlugin')->getValue(); + } + } $plugins = $this->resource->allLiterals('skosmos:usePlugin'); if ($plugins) { foreach ($plugins as $pluginlit) { diff --git a/tests/testconfig.ttl b/tests/testconfig.ttl index 923f404ec..8a2167a72 100644 --- a/tests/testconfig.ttl +++ b/tests/testconfig.ttl @@ -383,7 +383,7 @@ skosmos:feedbackRecipient "developer@vocabulary.org"; skosmos:groupClass skos:Collection; skosmos:language "en"; - skosmos:vocabularyPlugins ("plugin2" "Bravo" :parameterizedPlugin "plugin1"); + skosmos:vocabularyPlugins ("plugin2" "Bravo" "plugin1"); skosmos:usePlugin "plugin1" ; skosmos:usePlugin "plugin3" ; skosmos:useParamPlugin :parameterizedPlugin ; From 5ce6c7437f7023c9930c51b50a47a764f5a35e8f Mon Sep 17 00:00:00 2001 From: Joeli Takala Date: Wed, 2 Mar 2022 10:23:31 +0200 Subject: [PATCH 3/8] Added missing updated tests --- tests/VocabularyConfigTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/VocabularyConfigTest.php b/tests/VocabularyConfigTest.php index e87440883..ce5514a2f 100644 --- a/tests/VocabularyConfigTest.php +++ b/tests/VocabularyConfigTest.php @@ -552,7 +552,7 @@ public function testGetPluginParameters() { public function testGetOrderedPlugins() { $vocab = $this->model->getVocabulary('paramPluginTest'); $plugins = $vocab->getConfig()->getPluginArray(); - $this->assertEquals(["plugin2", "Bravo", "imaginaryPlugin", "plugin1", "alpha", "charlie", "plugin3"], $plugins); + $this->assertEquals(["plugin2", "Bravo", "plugin1", "alpha", "charlie", "imaginaryPlugin", "plugin3"], $plugins); } /** From f67f20d036ae183a4d21f3da75ee6162e499ec9c Mon Sep 17 00:00:00 2001 From: Vainonen Date: Wed, 2 Mar 2022 16:27:41 +0200 Subject: [PATCH 4/8] Improved PluginRegister tests --- model/PluginRegister.php | 17 +++++++++-- tests/PluginRegisterTest.php | 55 ++++++++++++++++++++++++++++++------ 2 files changed, 62 insertions(+), 10 deletions(-) diff --git a/model/PluginRegister.php b/model/PluginRegister.php index 1f2f49393..339aa445e 100644 --- a/model/PluginRegister.php +++ b/model/PluginRegister.php @@ -129,6 +129,19 @@ public function getTemplates($names=null) { return $templateStrings; } + /** + * Returns an array of plugin callback function names + * @param array $names the plugin name strings (foldernames) in an array + * @return array + */ + public function getPluginsCallbacks($names=null) { + if ($names) { + $names = array_merge($this->requestedPlugins, $names); + return $this->filterPluginsByName('callback', $names); + } + return $this->filterPluginsByName('callback', $this->requestedPlugins); + } + /** * Returns a sorted array of javascript function names to call when loading pages * in order configured with skosmos:vocabularyPlugins @@ -141,7 +154,7 @@ public function getCallbacks() { foreach ($this->requestedPlugins as $index => $value) { $order[$value] = $index; } - $plugins = $this->filterPluginsByName('callback', $this->requestedPlugins); + $plugins = $this->getPluginsCallbacks($this->requestedPlugins); foreach ($plugins as $callbacks) { foreach ($callbacks as $callback) { $split = explode('/', $callback); @@ -154,7 +167,7 @@ public function getCallbacks() { } return $ret; } - + /** * Returns an array that is flattened from its possibly multidimensional form * copied from https://stackoverflow.com/a/1320156 diff --git a/tests/PluginRegisterTest.php b/tests/PluginRegisterTest.php index a60c86f70..a35eabfb2 100644 --- a/tests/PluginRegisterTest.php +++ b/tests/PluginRegisterTest.php @@ -8,9 +8,44 @@ class PluginRegisterTest extends PHPUnit\Framework\TestCase protected function setUp() : void { - $this->mockpr = $this->getMockBuilder('PluginRegister')->setConstructorArgs(array(array('global-plugin')))->setMethods(array('getPlugins'))->getMock(); - $stubplugs = array ('test-plugin' => array ( 'js' => array ( 0 => 'first.js', 1 => 'second.min.js', ), 'css' => array ( 0 => 'stylesheet.css', ), 'templates' => array ( 0 => 'template.html', ), ), 'only-css' => array ( 'css' => array ( 0 => 'super.css')), 'global-plugin' => array('js' => array('everywhere.js'))); - $this->mockpr->method('getPlugins')->will($this->returnValue($stubplugs)); + $this->mockpr = $this->getMockBuilder('PluginRegister')->setConstructorArgs(array(array('test-plugin2', + 'global-plugin-Bravo', + 'imaginary-plugin', + 'test-plugin1', + 'global-plugin-alpha', + 'global-plugin-charlie', + 'test-plugin3' + ))) + ->setMethods(['getPlugins']) + ->getMock(); + $this->stubplugs = array ('imaginary-plugin' => array ( 'js' => array ( 0 => 'imaginaryPlugin.js', ), + 'css' => array ( 0 => 'stylesheet.css', ), + 'templates' => array ( 0 => 'template.html', ), + 'callback' => array ( 0 => 'imaginaryPlugin') + ), + 'test-plugin1' => array ( 'js' => array ( 0 => 'plugin1.js', 1 => 'second.min.js'), + 'css' => array ( 0 => 'stylesheet.css', ), + 'templates' => array ( 0 => 'template.html', ), + 'callback' => array ( 0 => 'callplugin1') + ), + 'test-plugin2' => array ( 'js' => array ( 0 => 'plugin2.js', ), + 'css' => array ( 0 => 'stylesheet.css', ), + 'templates' => array ( 0 => 'template.html', ), + 'callback' => array ( 0 => 'callplugin2') + ), + 'test-plugin3' => array ( 'js' => array ( 0 => 'plugin3.js', ), + 'css' => array ( 0 => 'stylesheet.css', ), + 'templates' => array ( 0 => 'template.html', ), + 'callback' => array ( 0 => 'callplugin3') + ), + 'only-css' => array ( 'css' => array ( 0 => 'super.css')), + 'global-plugin-alpha' => array('js' => array('alpha.js'), + 'callback' => array ( 0 => 'alpha')), + 'global-plugin-Bravo' => array('js' => array('Bravo.js'), + 'callback' => array ( 0 => 'bravo')), + 'global-plugin-charlie' => array('js' => array('charlie.js'), + 'callback' => array ( 0 => 'charlie'))); + $this->mockpr->method('getPlugins')->will($this->returnValue($this->stubplugs)); $this->model = new Model(new GlobalConfig('/../tests/testconfig.ttl')); $this->vocab = $this->model->getVocabulary('test'); } @@ -42,7 +77,8 @@ public function testGetPluginsJS() */ public function testGetPluginsJSWithName() { - $this->assertEquals(array('global-plugin' => array('plugins/global-plugin/everywhere.js'), 'test-plugin' => array('plugins/test-plugin/first.js', 'plugins/test-plugin/second.min.js')), $this->mockpr->getPluginsJS(array('test-plugin'))); + $this->assertEquals($this->mockpr->getPluginsJS()['test-plugin1'], + array('plugins/test-plugin1/plugin1.js', 'plugins/test-plugin1/second.min.js')); } /** @@ -53,7 +89,8 @@ public function testGetPluginsJSWithName() */ public function testGetPluginsJSWithGlobalPlugin() { - $this->assertEquals(array('global-plugin' => array('plugins/global-plugin/everywhere.js')), $this->mockpr->getPluginsJS()); + $this->assertEquals($this->mockpr->getPluginsJS()['global-plugin-alpha'], + array('plugins/global-plugin-alpha/alpha.js')); } /** @@ -73,7 +110,8 @@ public function testGetPluginsCSS() public function testGetPluginsCSSWithName() { $plugins = new PluginRegister(); - $this->assertEquals(array('test-plugin' => array('plugins/test-plugin/stylesheet.css')), $this->mockpr->getPluginsCSS(array('test-plugin'))); + $this->assertEquals($this->mockpr->getPluginsCSS()['test-plugin1'], + array('plugins/test-plugin1/stylesheet.css')); } /** @@ -99,8 +137,9 @@ public function testGetTemplates() */ public function testGetCallbacks() { - $plugins = new PluginRegister(); - $this->assertEquals(array(), $plugins->getCallbacks()); + $this->assertEquals($this->mockpr->getCallbacks(), + array('callplugin2', 'bravo', 'imaginaryPlugin', 'callplugin1', 'alpha', 'charlie', 'callplugin3') + ); } } From d546a4b102d370ba516c59a97feb299ec71d6fe1 Mon Sep 17 00:00:00 2001 From: Vainonen Date: Wed, 2 Mar 2022 17:08:53 +0200 Subject: [PATCH 5/8] Changed test vocabulary names --- tests/VocabularyConfigTest.php | 6 +++--- tests/testconfig.ttl | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/VocabularyConfigTest.php b/tests/VocabularyConfigTest.php index ce5514a2f..15ecb9c6c 100644 --- a/tests/VocabularyConfigTest.php +++ b/tests/VocabularyConfigTest.php @@ -541,7 +541,7 @@ public function testGetVocabularyUseModifiedDate() { * @covers VocabularyConfig::getPluginParameters */ public function testGetPluginParameters() { - $vocab = $this->model->getVocabulary('paramPluginTest'); + $vocab = $this->model->getVocabulary('paramPluginOrderTest'); $params = $vocab->getConfig()->getPluginParameters(); $this->assertEquals(array('imaginaryPlugin' => array('poem_fi' => "Roses are red", 'poem' => "Violets are blue", 'color' => "#800000")), $params); } @@ -550,7 +550,7 @@ public function testGetPluginParameters() { * @covers VocabularyConfig::getPluginArray */ public function testGetOrderedPlugins() { - $vocab = $this->model->getVocabulary('paramPluginTest'); + $vocab = $this->model->getVocabulary('paramPluginOrderTest'); $plugins = $vocab->getConfig()->getPluginArray(); $this->assertEquals(["plugin2", "Bravo", "plugin1", "alpha", "charlie", "imaginaryPlugin", "plugin3"], $plugins); } @@ -559,7 +559,7 @@ public function testGetOrderedPlugins() { * @covers VocabularyConfig::getPluginArray */ public function testGetUnorderedVocabularyPlugins() { - $vocab = $this->model->getVocabulary('paramPluginOrderTest'); + $vocab = $this->model->getVocabulary('paramPluginTest'); $plugins = $vocab->getConfig()->getPluginArray(); $arrayElements = ["plugin2", "Bravo", "imaginaryPlugin", "plugin1", "alpha", "charlie", "plugin3"]; $this->assertEquals(sort($arrayElements), sort($plugins)); diff --git a/tests/testconfig.ttl b/tests/testconfig.ttl index 8a2167a72..924da08db 100644 --- a/tests/testconfig.ttl +++ b/tests/testconfig.ttl @@ -362,7 +362,7 @@ skosmos:sparqlGraph ; skosmos:mainConceptScheme test:notationMainConceptScheme . -:paramPluginOrderTest a skosmos:Vocabulary, void:Dataset ; +:paramPluginTest a skosmos:Vocabulary, void:Dataset ; dc:title "Test plugin order"@en ; void:dataDump ; void:uriSpace "http://www.skosmos.skos/test/"; @@ -371,7 +371,7 @@ skosmos:usePlugin "plugin3" ; skosmos:useParamPlugin :parameterizedPlugin . -:paramPluginTest a skosmos:Vocabulary, void:Dataset ; +:paramPluginOrderTest a skosmos:Vocabulary, void:Dataset ; dc:title "Test plugin parameters"@en ; dc:subject :cat_science ; dc:type mdrtype:ONTOLOGY ; From fe7e502091cf73a9d138288f98d2c84561f54acf Mon Sep 17 00:00:00 2001 From: Vainonen Date: Wed, 2 Mar 2022 18:01:15 +0200 Subject: [PATCH 6/8] Added test for getPluginCallbacks --- model/PluginRegister.php | 4 ++-- tests/PluginRegisterTest.php | 13 ++++++++++++- 2 files changed, 14 insertions(+), 3 deletions(-) diff --git a/model/PluginRegister.php b/model/PluginRegister.php index 339aa445e..bb28f4b50 100644 --- a/model/PluginRegister.php +++ b/model/PluginRegister.php @@ -134,7 +134,7 @@ public function getTemplates($names=null) { * @param array $names the plugin name strings (foldernames) in an array * @return array */ - public function getPluginsCallbacks($names=null) { + public function getPluginCallbacks($names=null) { if ($names) { $names = array_merge($this->requestedPlugins, $names); return $this->filterPluginsByName('callback', $names); @@ -154,7 +154,7 @@ public function getCallbacks() { foreach ($this->requestedPlugins as $index => $value) { $order[$value] = $index; } - $plugins = $this->getPluginsCallbacks($this->requestedPlugins); + $plugins = $this->getPluginCallbacks($this->requestedPlugins); foreach ($plugins as $callbacks) { foreach ($callbacks as $callback) { $split = explode('/', $callback); diff --git a/tests/PluginRegisterTest.php b/tests/PluginRegisterTest.php index a35eabfb2..e8265368d 100644 --- a/tests/PluginRegisterTest.php +++ b/tests/PluginRegisterTest.php @@ -109,11 +109,22 @@ public function testGetPluginsCSS() */ public function testGetPluginsCSSWithName() { - $plugins = new PluginRegister(); $this->assertEquals($this->mockpr->getPluginsCSS()['test-plugin1'], array('plugins/test-plugin1/stylesheet.css')); } + /** + * @covers PluginRegister::getPluginCallbacks + * @covers PluginRegister::filterPlugins + * @covers PluginRegister::filterPluginsByName + */ + public function testGetPluginCallbacks() + { + $plugins = new PluginRegister(); + $this->assertEquals($this->mockpr->getPluginCallbacks()['test-plugin1'], + array('plugins/test-plugin1/callplugin1')); + } + /** * @covers PluginRegister::getPluginsTemplates */ From e38f2ff470c432c9baa07cb31678e22b718bb8c4 Mon Sep 17 00:00:00 2001 From: Vainonen Date: Thu, 3 Mar 2022 16:17:14 +0200 Subject: [PATCH 7/8] Added ordering of JS plugin scripts --- model/PluginRegister.php | 21 ++++++++++++++----- tests/PluginRegisterTest.php | 39 +++++++++++++++++++++++++++--------- view/concept-shared.twig | 2 ++ 3 files changed, 47 insertions(+), 15 deletions(-) diff --git a/model/PluginRegister.php b/model/PluginRegister.php index bb28f4b50..4635c50e5 100644 --- a/model/PluginRegister.php +++ b/model/PluginRegister.php @@ -5,6 +5,10 @@ class PluginRegister { public function __construct($requestedPlugins=array()) { $this->requestedPlugins = $requestedPlugins; + $this->pluginOrder = array(); + foreach ($this->requestedPlugins as $index => $value) { + $this->pluginOrder[$value] = $index; + } } /** @@ -24,6 +28,16 @@ protected function getPlugins() return $plugins; } + /** + * Sort plugins by order defined in class constructor + * @return array + */ + private function sortPlugins($plugins) { + $sortedPlugins = array(); + $sortedPlugins = array_replace($this->pluginOrder, $plugins); + return $sortedPlugins; + } + /** * Returns the plugin configurations found from plugin folders * inside the plugins folder filtered by filetype. @@ -33,6 +47,7 @@ protected function getPlugins() */ private function filterPlugins($type, $raw=false) { $plugins = $this->getPlugins(); + $plugins = $this->sortPlugins($plugins); $ret = array(); if (!empty($plugins)) { foreach ($plugins as $name => $files) { @@ -150,10 +165,6 @@ public function getPluginCallbacks($names=null) { public function getCallbacks() { $ret = array(); $sortedCallbacks = array(); - $order = array(); - foreach ($this->requestedPlugins as $index => $value) { - $order[$value] = $index; - } $plugins = $this->getPluginCallbacks($this->requestedPlugins); foreach ($plugins as $callbacks) { foreach ($callbacks as $callback) { @@ -161,7 +172,7 @@ public function getCallbacks() { $sortedCallbacks[$split[1]] = $split[2]; } } - $sortedCallbacks = array_replace($order, $sortedCallbacks); + $sortedCallbacks = array_replace($this->pluginOrder, $sortedCallbacks); foreach ($sortedCallbacks as $callback) { $ret[] = $callback; } diff --git a/tests/PluginRegisterTest.php b/tests/PluginRegisterTest.php index e8265368d..f75807228 100644 --- a/tests/PluginRegisterTest.php +++ b/tests/PluginRegisterTest.php @@ -69,6 +69,25 @@ public function testGetPluginsJS() $this->assertEquals(array(), $plugins->getPluginsJS()); } + /** + * @covers PluginRegister::getPlugins + * @covers PluginRegister::getPluginsJS + * @covers PluginRegister::filterPlugins + * @covers PluginRegister::filterPluginsByName + */ + public function testGetPluginsJSInOrder() + { + $this->assertEquals(['test-plugin2', + 'global-plugin-Bravo', + 'imaginary-plugin', + 'test-plugin1', + 'global-plugin-alpha', + 'global-plugin-charlie', + 'test-plugin3'], + array_keys($this->mockpr->getPluginsJS())); + + } + /** * @covers PluginRegister::getPlugins * @covers PluginRegister::getPluginsJS @@ -77,8 +96,8 @@ public function testGetPluginsJS() */ public function testGetPluginsJSWithName() { - $this->assertEquals($this->mockpr->getPluginsJS()['test-plugin1'], - array('plugins/test-plugin1/plugin1.js', 'plugins/test-plugin1/second.min.js')); + $this->assertEquals(array('plugins/test-plugin1/plugin1.js', 'plugins/test-plugin1/second.min.js'), + $this->mockpr->getPluginsJS()['test-plugin1']); } /** @@ -89,8 +108,8 @@ public function testGetPluginsJSWithName() */ public function testGetPluginsJSWithGlobalPlugin() { - $this->assertEquals($this->mockpr->getPluginsJS()['global-plugin-alpha'], - array('plugins/global-plugin-alpha/alpha.js')); + $this->assertEquals(array('plugins/global-plugin-alpha/alpha.js'), + $this->mockpr->getPluginsJS()['global-plugin-alpha']); } /** @@ -109,8 +128,8 @@ public function testGetPluginsCSS() */ public function testGetPluginsCSSWithName() { - $this->assertEquals($this->mockpr->getPluginsCSS()['test-plugin1'], - array('plugins/test-plugin1/stylesheet.css')); + $this->assertEquals(array('plugins/test-plugin1/stylesheet.css'), + $this->mockpr->getPluginsCSS()['test-plugin1']); } /** @@ -121,8 +140,8 @@ public function testGetPluginsCSSWithName() public function testGetPluginCallbacks() { $plugins = new PluginRegister(); - $this->assertEquals($this->mockpr->getPluginCallbacks()['test-plugin1'], - array('plugins/test-plugin1/callplugin1')); + $this->assertEquals(array('plugins/test-plugin1/callplugin1'), + $this->mockpr->getPluginCallbacks()['test-plugin1']); } /** @@ -148,8 +167,8 @@ public function testGetTemplates() */ public function testGetCallbacks() { - $this->assertEquals($this->mockpr->getCallbacks(), - array('callplugin2', 'bravo', 'imaginaryPlugin', 'callplugin1', 'alpha', 'charlie', 'callplugin3') + $this->assertEquals(array('callplugin2', 'bravo', 'imaginaryPlugin', 'callplugin1', 'alpha', 'charlie', 'callplugin3'), + $this->mockpr->getCallbacks() ); } diff --git a/view/concept-shared.twig b/view/concept-shared.twig index 36d1d69ec..664ee839e 100644 --- a/view/concept-shared.twig +++ b/view/concept-shared.twig @@ -12,6 +12,7 @@

{% trans %}There is no term for this concept in this language{% endtrans %}

{% endif %} +
{% if bread_crumbs is defined %} @@ -208,6 +209,7 @@ >
+
{% endfor %} {% else %} From 9958dbb76c5824dce9e08e208fa607adb58af54c Mon Sep 17 00:00:00 2001 From: Osma Suominen Date: Fri, 4 Mar 2022 17:50:44 +0200 Subject: [PATCH 8/8] Add coverage annotations for new sortPlugins method --- tests/PluginRegisterTest.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/PluginRegisterTest.php b/tests/PluginRegisterTest.php index f75807228..8d4e1b5ee 100644 --- a/tests/PluginRegisterTest.php +++ b/tests/PluginRegisterTest.php @@ -74,6 +74,7 @@ public function testGetPluginsJS() * @covers PluginRegister::getPluginsJS * @covers PluginRegister::filterPlugins * @covers PluginRegister::filterPluginsByName + * @covers PluginRegister::sortPlugins */ public function testGetPluginsJSInOrder() { @@ -93,6 +94,7 @@ public function testGetPluginsJSInOrder() * @covers PluginRegister::getPluginsJS * @covers PluginRegister::filterPlugins * @covers PluginRegister::filterPluginsByName + * @covers PluginRegister::sortPlugins */ public function testGetPluginsJSWithName() { @@ -105,6 +107,7 @@ public function testGetPluginsJSWithName() * @covers PluginRegister::getPluginsJS * @covers PluginRegister::filterPlugins * @covers PluginRegister::filterPluginsByName + * @covers PluginRegister::sortPlugins */ public function testGetPluginsJSWithGlobalPlugin() { @@ -125,6 +128,7 @@ public function testGetPluginsCSS() * @covers PluginRegister::getPluginsCSS * @covers PluginRegister::filterPlugins * @covers PluginRegister::filterPluginsByName + * @covers PluginRegister::sortPlugins */ public function testGetPluginsCSSWithName() { @@ -136,6 +140,7 @@ public function testGetPluginsCSSWithName() * @covers PluginRegister::getPluginCallbacks * @covers PluginRegister::filterPlugins * @covers PluginRegister::filterPluginsByName + * @covers PluginRegister::sortPlugins */ public function testGetPluginCallbacks() {