fix(css): disable minification when using uglify (#383)

* fix(css): disable minification when using uglify related to #154, #135 fixes #377 * refactor: inline css-loader options
NativeScript · Jan 9, 2018 · 8e1a5a6 · 8e1a5a6
1 parent 8a20502
commit 8e1a5a6
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 6 deletions.
diff --git a/templates/webpack.angular.js b/templates/webpack.angular.js
@@ -60,8 +60,20 @@ module.exports = env => {
                 { test: /\.html$|\.xml$/, use: "raw-loader" },
 
                 // tns-core-modules reads the app.css and its imports using css-loader
-                { test: /[\/|\\]app\.css$/, use: "css-loader?url=false" },
-                { test: /[\/|\\]app\.scss$/, use: ["css-loader?url=false", "sass-loader"] },
+                {
+                    test: /[\/|\\]app\.css$/,
+                    use: {
+                        loader: "css-loader",
+                        options: { minimize: false, url: false },
+                    }
+                },
+                {
+                    test: /[\/|\\]app\.scss$/,
+                    use: [
+                        { loader: "css-loader", options: { minimize: false, url: false } },
+                        "sass-loader"
+                    ]
+                },
 
                 // Angular components reference css files and their imports using raw-loader
                 { test: /\.css$/, exclude: /[\/|\\]app\.css$/, use: "raw-loader" },

diff --git a/templates/webpack.javascript.js b/templates/webpack.javascript.js
@@ -57,8 +57,18 @@ module.exports = env => {
             rules: [
                 { test: /\.(html|xml)$/, use: "raw-loader" },
 
-                { test: /\.css$/, use: "css-loader?url=false" },
-                { test: /\.scss$/, use: ["css-loader?url=false", "sass-loader"] },
+                {
+                    test: /\.css$/,
+                    use: { loader: "css-loader", options: { minimize: false, url: false } }
+                },
+
+                {
+                    test: /\.scss$/,
+                    use: [
+                        { loader: "css-loader", options: { minimize: false, url: false } },
+                        "sass-loader"
+                    ]
+                }
             ]
         },
         plugins: [

diff --git a/templates/webpack.typescript.js b/templates/webpack.typescript.js
@@ -57,8 +57,18 @@ module.exports = env => {
             rules: [
                 { test: /\.(html|xml)$/, use: "raw-loader" },
 
-                { test: /\.css$/, use: "css-loader?url=false" },
-                { test: /\.scss$/, use: ["css-loader?url=false", "sass-loader"] },
+                {
+                    test: /\.css$/,
+                    use: { loader: "css-loader", options: { minimize: false, url: false } }
+                },
+
+                {
+                    test: /\.scss$/,
+                    use: [
+                        { loader: "css-loader", options: { minimize: false, url: false } },
+                        "sass-loader"
+                    ]
+                },
 
                 { test: /\.ts$/, use: "awesome-typescript-loader" }
             ]