Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

Commit

Permalink
feat: configure v8Version for snapshot tools (#503)
Browse files Browse the repository at this point in the history
* Read v8 version from webpack.config.js

* use options instead of this.options
  • Loading branch information
vtrifonov authored and sis0k0 committed Apr 25, 2018
1 parent 41779ad commit cf0d76b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions plugins/NativeScriptSnapshotPlugin/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ exports.NativeScriptSnapshotPlugin = (function() {
targetArchs: options.targetArchs,
useLibs: options.useLibs,
androidNdkPath: options.androidNdkPath,
v8Version: options.v8Version,
tnsJavaClassesPath: join(preparedAppRootPath, "tns-java-classes.js")
}).then(() => {
// Make the original file empty
Expand Down
3 changes: 3 additions & 0 deletions plugins/NativeScriptSnapshotPlugin/options.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
},
"useLibs": {
"type": "boolean"
},
"v8Version": {
"type": "string"
}
},
"additionalProperties": false
Expand Down

0 comments on commit cf0d76b

Please sign in to comment.