This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
fix(template): disable minification of css by css-loader #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When uglify is used, it triggers the minification option of the css-loader. The css-loader uses internally cssnano to optimize the size of the stylesheets. Since NativeScript supports only a subset of the CSS language, many of these optimizations may be damaging for the user's css. Such is the case with `background-position`: center, which gets translated to `background-position`: 50%, which is currently not working in NativeScript 3.0 (NativeScript/NativeScript#4201). closes #135
sis0k0
force-pushed
the
vlaeva/css-loader-minify
branch
from
97b0edf to
5f5686b
Compare
sis0k0
added a commit
that referenced
this pull request
Jan 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When uglify is used, it triggers the minification option of the
css-loader. The css-loader uses internally cssnano to optimize the size
of the stylesheets. Since NativeScript supports only a subset of the CSS language, many of these optimizations may be damaging for the user's css.
Such is the case with
background-position: center, which getstranslated to
background-position: 50%, which is currently not workingin NativeScript 3.0 (NativeScript/NativeScript#4201).
closes #135