Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

fix(hooks): after-watch hook is not executed #483

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

rosen-vladimirov
Copy link
Contributor

The after-watch hook is not executed as it is not registered in the package.json. So it is never created in the projects, so the webpack process is not stopped when LiveSync should stop.
In CLI process this is not a problem, but this is a huge issue for Sidekick, as the webpack watcher keeps watching the project and executes some actions.

Also fix the code in the hook itself - the webpack variable does not exist.

PR Checklist

What is the current behavior?

When webpack is used for LiveSync, once the LiveSync operation should stop, the after watch hook should be executed. As it is never registered in the project, the webpack watcher remains alive and continues watching the project.

What is the new behavior?

When the LiveSync should be stopped, the after-watch hook is executed and the webpack process is killed.

The `after-watch` hook is not executed as it is not registered in the package.json. So it is never created in the projects, so the webpack process is not stopped when LiveSync should stop.
In CLI process this is not a problem, but this is a huge issue for Sidekick, as the webpack watcher keeps watching the project and executes some actions.
@SvetoslavTsenov
Copy link
Contributor

test

@rosen-vladimirov rosen-vladimirov merged commit a61cff4 into master Apr 4, 2018
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-after-watch-hook branch April 4, 2018 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants