This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
fix(hooks): after-watch
hook is not executed
#483
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
after-watch
hook is not executed as it is not registered in the package.json. So it is never created in the projects, so the webpack process is not stopped when LiveSync should stop.In CLI process this is not a problem, but this is a huge issue for Sidekick, as the webpack watcher keeps watching the project and executes some actions.
Also fix the code in the hook itself - the
webpack
variable does not exist.PR Checklist
What is the current behavior?
When webpack is used for LiveSync, once the LiveSync operation should stop, the after watch hook should be executed. As it is never registered in the project, the webpack watcher remains alive and continues watching the project.
What is the new behavior?
When the LiveSync should be stopped, the after-watch hook is executed and the webpack process is killed.