Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

Require modules dynamically when generating snapshot #511

Closed
3 tasks done
sis0k0 opened this issue Apr 29, 2018 · 0 comments · Fixed by #513
Closed
3 tasks done

Require modules dynamically when generating snapshot #511

sis0k0 opened this issue Apr 29, 2018 · 0 comments · Fixed by #513
Labels

Comments

@sis0k0
Copy link
Contributor

sis0k0 commented Apr 29, 2018

Issue Checklist

  • You are submitting: a feature request
  • You verified that this is a real problem by searching the [NativeScript Forum] and the other [issues] in this repo.
  • You checked our [demo apps] and the [documentation] for sample usage.

Problem

Currently, the modules that are executed when generating snapshots are the ones that are required in the vendor.ts file. With webpack 4 all node packages that are used in the app will be moved to one separate chunk. That makes the vendor.ts only needed when generating snapshots.

Proposed solution

We can dynamically generate requires for the modules that should be executed and add them to the 'snapshotted' chunk. That way, we won't need a separate vendor.ts file.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant