Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

fix: lazy-ngmodule-hot-loader breaks the sourceMaps #770

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

rosen-vladimirov
Copy link
Contributor

@rosen-vladimirov rosen-vladimirov commented Jan 24, 2019

The lazy-ngmodule-hot-loader breaks sourceMaps as it does not pass them to the next loaders. This breaks debugging with --bundle in VSCode extension as the files included in the sourcesContent cannot be mapped correctly to local files.

PR Checklist

What is the current behavior?

  • Unable to debug Angular projects in VSCode.
  • When debugging Angular projects in Chrome DevTools, the content of the files under webpack is not the same as your actual content - it's not TypeScript anymore:
    webpack_incorrect_sources

What is the new behavior?

  • You can debug Angular projects in VSCode
  • Sources under webpack in Chrome DevTools are correct

Fixes nativescript-community/nativescript-vscode-extension#232

The `lazy-ngmodule-hot-loader` breaks sourceMaps as it does not pass them to the next loaders. This breaks debugging with `--bundle` in VSCode extension as the files included in the `sourcesContent` cannot be mapped correctly to local files.
Copy link
Contributor

@sis0k0 sis0k0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! @dtopuzov, @rosen-vladimirov , is there a way to execute tests for debugging on PR of the webpack plugin?

@rosen-vladimirov rosen-vladimirov merged commit 3fccf86 into master Jan 25, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-lazy-loading-loader branch January 25, 2019 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants