Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

fix: execute bundle-config-loader only for the entry point of the application #829

Merged
merged 3 commits into from
Mar 19, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Mar 14, 2019

Currently bundle-config-loader is executed for any file of the application with the same name as main entry file. For example if the javascript application has app.js file located in ./app/some-folder/app.js, the bundle-config-loader will be executed for this file.

PR Checklist

What is the current behavior?

bundle-config-loader is executed for any file of the application with the same name as main entry file

What is the new behavior?

bundle-config-loader is executed only for the entry point of the application

Fixes/Implements/Closes #[Issue Number].

…lication

Currently bundle-config-loader is executed for any file of the application with the same name as main entry file. For example if the javascript application has app.js file located in ./app/some-folder/app.js, the bundle-config-loader will be executed for this file.
@ghost ghost assigned Fatme Mar 14, 2019
@ghost ghost added the review label Mar 14, 2019
@cla-bot cla-bot bot added the cla: yes label Mar 14, 2019
@Fatme
Copy link
Contributor Author

Fatme commented Mar 15, 2019

test package_version#latest

1 similar comment
@Fatme
Copy link
Contributor Author

Fatme commented Mar 19, 2019

test package_version#latest

@Fatme Fatme merged commit 36824b1 into master Mar 19, 2019
@ghost ghost removed the review label Mar 19, 2019
@Fatme Fatme deleted the fatme/bundle-config-loader branch March 19, 2019 12:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants