fix: don't include partial scss files in bundle #988

vakrilov · 2019-07-15T19:38:52Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the [CLA].
All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests
Tests for the changes are included.

Partial .scss are included in the bundle by BundleConfigLoader.

Partial .scss are not included in the bundle by BundleConfigLoader.

bundle-config-loader.ts

package.json

rosen-vladimirov

Awesome work, I love the tests!

vakrilov · 2019-07-16T07:31:05Z

test branch_ngapps#release ngapps#release

fix: don't include partial scss files in bundle

5f74e91

vakrilov requested a review from DimitarTachev July 15, 2019 19:38

cla-bot bot added the cla: yes label Jul 15, 2019

vakrilov requested a review from rosen-vladimirov July 15, 2019 20:23

rosen-vladimirov reviewed Jul 15, 2019

View reviewed changes

bundle-config-loader.ts Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

fix: imporve regex after review

24664aa

rosen-vladimirov approved these changes Jul 16, 2019

View reviewed changes

vakrilov merged commit 786bd6c into release Jul 16, 2019

vakrilov deleted the patial-scss branch July 16, 2019 08:45