From 69b539602f8bd1b33704b8654dde740cc7a9f965 Mon Sep 17 00:00:00 2001
From: Max Horn <max@quendi.de>
Date: Mon, 9 Dec 2024 13:00:11 +0100
Subject: [PATCH] Stop using fmpz_mod_mat_rank again

---
 src/flint/fmpz_mod_mat.jl | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/src/flint/fmpz_mod_mat.jl b/src/flint/fmpz_mod_mat.jl
index 8cd3dd39c..0cfbbbf09 100644
--- a/src/flint/fmpz_mod_mat.jl
+++ b/src/flint/fmpz_mod_mat.jl
@@ -389,11 +389,18 @@ end
 #
 ################################################################################
 
+#= There are some doubts whether fmpz_mod_mat_rank is what we want: there are
+several non-equivalent ways to define the rank of a matrix over a ring with
+zero divisors. FLINT does not seem to document what exactly fmpz_mod_mat_rank
+computes...
+
 function rank(a::T) where T <: Zmod_fmpz_mat
   r = @ccall libflint.fmpz_mod_mat_rank(a::Ref{T}, base_ring(a).ninv::Ref{fmpz_mod_ctx_struct})::Int
   return r
 end
 
+=#
+
 ################################################################################
 #
 #  Inverse