chore: remove unused overlay theme keys

These weren't used, but I'd like to have something like this in the future. Not eaxactly sure what the api should be (settings/theme)
Nerixyz · Sep 30, 2024 · c271272 · c271272
1 parent c829dcb
commit c271272
Show file tree

Hide file tree

Showing 7 changed files with 1 addition and 40 deletions.
diff --git a/docs/ChatterinoTheme.schema.json b/docs/ChatterinoTheme.schema.json
@@ -293,19 +293,12 @@
             "backgrounds": { "$ref": "#/definitions/message-backgrounds" },
             "disabled": { "$ref": "#/definitions/qt-color" },
             "selection": { "$ref": "#/definitions/qt-color" },
-            "textColors": { "$ref": "#/definitions/text-colors" },
             "background": {
               "$ref": "#/definitions/qt-color",
               "description": "Note: The alpha value is ignored (set through the settings)"
             }
           },
-          "required": [
-            "backgrounds",
-            "disabled",
-            "selection",
-            "textColors",
-            "background"
-          ]
+          "required": ["backgrounds", "disabled", "selection", "background"]
         },
         "scrollbars": {
           "type": "object",

diff --git a/resources/themes/Black.json b/resources/themes/Black.json
@@ -29,13 +29,6 @@
       },
       "disabled": "#64000000",
       "selection": "#40ffffff",
-      "textColors": {
-        "caret": "#ffffff",
-        "chatPlaceholder": "#5d5555",
-        "link": "#4286f4",
-        "regular": "#ffffff",
-        "system": "#8c7f7f"
-      },
       "background": "#000"
     },
     "scrollbars": {

diff --git a/resources/themes/Dark.json b/resources/themes/Dark.json
@@ -29,13 +29,6 @@
       },
       "disabled": "#64000000",
       "selection": "#40ffffff",
-      "textColors": {
-        "caret": "#ffffff",
-        "chatPlaceholder": "#5d5555",
-        "link": "#4286f4",
-        "regular": "#ffffff",
-        "system": "#8c7f7f"
-      },
       "background": "#000"
     },
     "scrollbars": {

diff --git a/resources/themes/Light.json b/resources/themes/Light.json
@@ -29,13 +29,6 @@
       },
       "disabled": "#64ffffff",
       "selection": "#40ffffff",
-      "textColors": {
-        "caret": "#000000",
-        "chatPlaceholder": "#af9f9f",
-        "link": "#4286f4",
-        "regular": "#000000",
-        "system": "#8c7f7f"
-      },
       "background": "#fff"
     },
     "scrollbars": {

diff --git a/resources/themes/White.json b/resources/themes/White.json
@@ -29,13 +29,6 @@
       },
       "disabled": "#64ffffff",
       "selection": "#40ffffff",
-      "textColors": {
-        "caret": "#000000",
-        "chatPlaceholder": "#af9f9f",
-        "link": "#4286f4",
-        "regular": "#000000",
-        "system": "#8c7f7f"
-      },
       "background": "#fff"
     },
     "scrollbars": {

diff --git a/src/singletons/Theme.cpp b/src/singletons/Theme.cpp
@@ -157,9 +157,6 @@ void parseOverlayMessages(const QJsonObject &overlayMessages,
                           const QJsonObject &overlayMessagesFallback,
                           chatterino::Theme &theme)
 {
-    parseTextColors(overlayMessages["textColors"_L1].toObject(),
-                    overlayMessagesFallback["textColors"_L1].toObject(),
-                    theme.overlayMessages);
     parseMessageBackgrounds(
         overlayMessages["backgrounds"_L1].toObject(),
         overlayMessagesFallback["backgrounds"_L1].toObject(),

diff --git a/src/singletons/Theme.hpp b/src/singletons/Theme.hpp
@@ -108,7 +108,6 @@ class Theme final
     } messages;
 
     struct {
-        TextColors textColors;
         MessageBackgrounds backgrounds;
 
         QColor disabled;