Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

普通网络请求也需要有取消的api暴露 #1178

Closed
chenkefeng opened this issue Nov 19, 2018 · 2 comments
Closed

普通网络请求也需要有取消的api暴露 #1178

chenkefeng opened this issue Nov 19, 2018 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@chenkefeng
Copy link

问题描述
对于原生微信小程序来说,普通的网络请求(wx.request,返回的是一个RequestTask,可取消)也有取消请求相关api,但是Taro中只对upload,download这两种有取消api暴露。

当前Taro中逻辑:

if (key === 'uploadFile' || key === 'downloadFile') {
  p.progress = cb => {
    if (task) {
       task.onProgressUpdate(cb)
    }
    return p
  }
  p.abort = cb => {
    cb && cb()
    if (task) {
       task.abort()
    }
    return p
  }
}

期望: 把普通的request也暴露出abort 相关方法用于取消网络请求

@taro-bot
Copy link

taro-bot bot commented Nov 19, 2018

欢迎提交 Issue~

如果你提交的是 bug 报告,请务必遵循 Issue 模板的规范,尽量用简洁的语言描述你的问题,最好能提供一个稳定简单的复现。🙏🙏🙏

如果你的信息提供过于模糊或不足,或者已经其他 issue 已经存在相关内容,你的 issue 有可能会被关闭。

Good luck and happy coding~

@luckyadam luckyadam self-assigned this Nov 19, 2018
@luckyadam luckyadam added the enhancement New feature or request label Nov 19, 2018
@taro-bot
Copy link

taro-bot bot commented Nov 20, 2018

CC @Chant-Lee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants