From 67a7c2adca1a71ad0fef67898334fdcea493a09a Mon Sep 17 00:00:00 2001 From: Steve Woodcock Date: Fri, 24 Feb 2023 14:11:04 +0000 Subject: [PATCH] Invoice shipping_tax_code should be a record_ref Per the NetSuite schema browser the Invoice shipping_tax_code should be a record_ref, since at least API version 2014_1. --- lib/netsuite/records/invoice.rb | 5 +++-- spec/netsuite/records/invoice_spec.rb | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/netsuite/records/invoice.rb b/lib/netsuite/records/invoice.rb index eb2aeec4..a8984025 100644 --- a/lib/netsuite/records/invoice.rb +++ b/lib/netsuite/records/invoice.rb @@ -25,7 +25,7 @@ class Invoice :other_ref_num, :partners_list, :rev_rec_end_date, :rev_rec_on_rev_commitment, :rev_rec_schedule, :rev_rec_start_date, :revenue_status, :sales_effective_date, :sales_group, :sales_team_list, :ship_date, :ship_group_list, - :shipping_cost, :shipping_tax_1_rate, :shipping_tax_2_rate, :shipping_tax_code, :source, :start_date, + :shipping_cost, :shipping_tax_1_rate, :shipping_tax_2_rate, :source, :start_date, :status, :sync_partner_teams, :sync_sales_teams, :tax_2_total, :tax_total, :time_disc_amount, :time_disc_print, :time_disc_rate, :time_disc_tax_1_amt, :time_disc_taxable, :time_discount, :time_list, :time_tax_code, :time_tax_rate_1, :time_tax_rate_2, :to_be_emailed, :to_be_faxed, @@ -138,7 +138,8 @@ class Invoice record_refs :account, :bill_address_list, :custom_form, :department, :entity, :klass, :partner, :posting_period, :ship_address_list, :terms, :location, :sales_rep, :tax_item, :created_from, - :ship_method, :lead_source, :promo_code, :subsidiary, :currency, :approval_status, :job, :discount_item + :ship_method, :lead_source, :promo_code, :subsidiary, :currency, :approval_status, :job, :discount_item, + :shipping_tax_code attr_reader :internal_id attr_accessor :external_id diff --git a/spec/netsuite/records/invoice_spec.rb b/spec/netsuite/records/invoice_spec.rb index e903459b..4631fab5 100644 --- a/spec/netsuite/records/invoice_spec.rb +++ b/spec/netsuite/records/invoice_spec.rb @@ -21,7 +21,7 @@ :other_ref_num, :partners_list, :rev_rec_end_date, :rev_rec_on_rev_commitment, :rev_rec_schedule, :rev_rec_start_date, :revenue_status, :sales_effective_date, :sales_group, :sales_team_list, :ship_address, :ship_date, :ship_group_list, - :shipping_cost, :shipping_tax_1_rate, :shipping_tax_2_rate, :shipping_tax_code, :source, :start_date, + :shipping_cost, :shipping_tax_1_rate, :shipping_tax_2_rate, :source, :start_date, :status, :sync_partner_teams, :sync_sales_teams, :tax_2_total, :tax_total, :time_disc_amount, :time_disc_print, :time_disc_rate, :time_disc_tax_1_amt, :time_disc_taxable, :time_discount, :time_list, :time_tax_code, :time_tax_rate_1, :time_tax_rate_2, :to_be_emailed, :to_be_faxed, @@ -151,7 +151,8 @@ it 'has the right record_refs' do [ :account, :bill_address_list, :job, :custom_form, :department, :entity, :klass, :posting_period, :ship_address_list, :terms, - :created_from, :location, :sales_rep, :ship_method, :tax_item, :partner, :lead_source, :promo_code, :subsidiary, :discount_item + :created_from, :location, :sales_rep, :ship_method, :tax_item, :partner, :lead_source, :promo_code, :subsidiary, :discount_item, + :shipping_tax_code ].each do |record_ref| expect(invoice).to have_record_ref(record_ref) end