From 11825f5d261a194909aa6e28824bfc2bc28c9260 Mon Sep 17 00:00:00 2001 From: kevgliss Date: Thu, 3 Aug 2023 15:40:59 -0700 Subject: [PATCH] Use the correct filter (#3662) * Use the correct filter * Ruff --- src/dispatch/signal/service.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/dispatch/signal/service.py b/src/dispatch/signal/service.py index aa4094a048f6..a43179e65ccc 100644 --- a/src/dispatch/signal/service.py +++ b/src/dispatch/signal/service.py @@ -18,7 +18,6 @@ from dispatch.tag import service as tag_service from dispatch.workflow import service as workflow_service from dispatch.entity.models import Entity -from dispatch.models import PrimaryKey from .models import ( Signal, @@ -208,11 +207,12 @@ def get_signal_instance( ) -def get(*, db_session: Session, signal_id: Union[PrimaryKey, str]) -> Optional[Signal]: +def get(*, db_session: Session, signal_id: Union[str, int]) -> Optional[Signal]: """Gets a signal by id or external_id.""" - signal = db_session.query(Signal).filter(Signal.id == signal_id).one_or_none() - if not signal: - signal = db_session.query(Signal).filter(Signal.external_id == str(signal_id)).one_or_none() + if isinstance(signal_id, int): + signal = db_session.query(Signal).filter(Signal.id == signal_id).one_or_none() + else: + signal = db_session.query(Signal).filter(Signal.external_id == signal_id).one_or_none() return signal