From 9d1172e2351ca68af64dbb12142a030ef846ee72 Mon Sep 17 00:00:00 2001 From: brharrington Date: Wed, 31 Aug 2016 14:07:30 -0700 Subject: [PATCH] remove rxnetty metrics module (#270) We typically use the http request level metrics to understand what the clients are doing. The lower level rxnetty metrics aren't used much and don't follow the recommended conventions so we would prefer not to publish them for our apps by default. An app owner can explicitly enable if they are still desirable in certain use-cases. --- build.sbt | 1 - .../src/main/java/com/netflix/iep/rxnetty/RxNettyModule.java | 3 --- 2 files changed, 4 deletions(-) diff --git a/build.sbt b/build.sbt index 3048d486..fe278499 100644 --- a/build.sbt +++ b/build.sbt @@ -137,7 +137,6 @@ lazy val `iep-module-rxnetty` = project Dependencies.guiceCore, Dependencies.rxnettyCore, Dependencies.rxnettyCtxts, - Dependencies.rxnettySpectator, Dependencies.slf4jApi )) diff --git a/iep-module-rxnetty/src/main/java/com/netflix/iep/rxnetty/RxNettyModule.java b/iep-module-rxnetty/src/main/java/com/netflix/iep/rxnetty/RxNettyModule.java index d7e14966..fd45fe5a 100644 --- a/iep-module-rxnetty/src/main/java/com/netflix/iep/rxnetty/RxNettyModule.java +++ b/iep-module-rxnetty/src/main/java/com/netflix/iep/rxnetty/RxNettyModule.java @@ -26,8 +26,6 @@ import com.netflix.iep.http.EurekaServerRegistry; import com.netflix.iep.http.RxHttp; import com.netflix.iep.http.ServerRegistry; -import io.reactivex.netty.RxNetty; -import io.reactivex.netty.spectator.SpectatorEventsListenerFactory; import javax.inject.Singleton; @@ -58,7 +56,6 @@ ServerRegistry getServerRegistry() { } @Override protected void configure() { - RxNetty.useMetricListenersFactory(new SpectatorEventsListenerFactory()); } @Provides