-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix maven missing deps: upgrade nebula + gradle #693
Changes from all commits
dfd7613
6dfa670
dc3f53a
a191c2d
9160633
378cc7f
6bd043d
c7c92f1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -22,16 +22,17 @@ buildscript { | |
url "https://plugins.gradle.org/m2/" | ||
} | ||
maven { url 'https://artifacts-oss.netflix.net/maven-oss-releases' } | ||
maven { url 'https://artifacts-oss.netflix.net/maven-oss-candidates' } | ||
} | ||
dependencies { | ||
classpath 'com.netflix.nebula:gradle-netflixoss-project-plugin:10.6.0' | ||
classpath 'com.netflix.nebula:gradle-netflixoss-project-plugin:11.5.0' | ||
classpath 'com.netflix.nebula:nebula-dependency-recommender:11.+' | ||
classpath 'io.mantisrx:mantis-gradle-plugin:1.2.+' | ||
classpath "io.freefair.gradle:lombok-plugin:5.3.3.3" | ||
classpath 'io.mantisrx:mantis-gradle-plugin:1.2.7-rc.4' | ||
classpath "io.freefair.gradle:lombok-plugin:6.+" | ||
classpath 'eu.appsatori:gradle-fatjar-plugin:0.3' | ||
classpath("gradle.plugin.com.github.jengelman.gradle.plugins:shadow:7.0.0") | ||
classpath("com.github.johnrengelman:shadow:8.1.1") | ||
classpath 'gradle.plugin.org.inferred:gradle-processors:3.3.0' | ||
classpath 'com.palantir.baseline:gradle-baseline-java:4.0.0' | ||
// classpath 'com.palantir.baseline:gradle-baseline-java:4.+' | ||
classpath 'com.bmuschko:gradle-docker-plugin:6.7.0' | ||
classpath "com.palantir.gradle.gitversion:gradle-git-version:3.0.0" | ||
} | ||
|
@@ -104,9 +105,8 @@ project.snapshot.configure { finalizedBy printAllReleasedArtifacts } | |
subprojects { | ||
apply plugin: 'java-library' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How about we add explicit dep on jar task for control-plane project here in There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a specific handling between control-plane-core etc. and it feels a bit too generic to add these rules for all sub-proj? |
||
|
||
// Apply lombok plugin and disabled the default config file generation. | ||
// Apply lombok plugin. | ||
apply plugin: "io.freefair.lombok" | ||
generateLombokConfig.enabled = false | ||
lombok { | ||
version = "1.18.20" | ||
} | ||
|
@@ -186,4 +186,4 @@ subprojects { | |
} | ||
} | ||
|
||
apply from: file('baseline.gradle') | ||
// apply from: file('baseline.gradle') |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.8-bin.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,8 +14,6 @@ | |
* limitations under the License. | ||
*/ | ||
|
||
apply plugin: 'mantis' | ||
|
||
ext { | ||
gsonVersion = '2.8.+' | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -59,3 +59,4 @@ task copyLibs(type: Copy) { | |
} | ||
|
||
jar.dependsOn copyLibs | ||
compileTestFixturesJava.dependsOn copyLibs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete altogether instead of commenting?