Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Fix Node 6 support #155

Closed
jasonmit opened this issue Jan 8, 2019 · 6 comments
Closed

CI: Fix Node 6 support #155

jasonmit opened this issue Jan 8, 2019 · 6 comments
Assignees
@jasonmit
Labels
dependency issue

Comments

@jasonmit
Copy link
Contributor

jasonmit commented Jan 8, 2019

https://travis-ci.org/Netflix/pollyjs/jobs/477047132
@jasonmit jasonmit added the bug 🐞 Something isn't working label Jan 8, 2019
@jasonmit jasonmit self-assigned this Jan 9, 2019
@jasonmit
Copy link
Contributor Author

jasonmit commented Jan 9, 2019 •
edited
Loading

The fix: request/request-promise-native#33

Once versioned will fix the build pipeline for Node 6.

@Turbo87
Copy link

Turbo87 commented Jan 14, 2019

@jasonmit FWIW you can use yarn resolutions to work around the issue for now :-/

@jasonmit
Copy link
Contributor Author

Yes but wouldn't fix for consumers, so didn't take that approach.

@Turbo87
Copy link

Turbo87 commented Jan 14, 2019

Sure, makes sense

@jasonmit jasonmit added dependency issue and removed bug 🐞 Something isn't working labels Jan 14, 2019
@offirgolan
Copy link
Collaborator

Resolved by #167

@jasonmit
Copy link
Contributor Author

FYI, this should now be resolved. Upstream bug fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonmit jasonmit

Labels
dependency issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Turbo87 @offirgolan @jasonmit