Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Gnosis beacon chain push withdrawals #5160

Merged
merged 58 commits into from
Apr 3, 2023
Merged

Implement Gnosis beacon chain push withdrawals #5160

merged 58 commits into from
Apr 3, 2023

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Jan 18, 2023 •
edited
Loading

Resolves #5159

Changes

  • Added Aura-specific withdrawal processor
  • Added withdrawal contract wrapper

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a fix or a feature that would cause existing functionality not to work as expected)
  • Documentation update
  • Code style update (formatting, renaming)
  • Refactoring (no functional or API changes)
  • Build-related changes
  • Other: description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@rubo rubo added eip gnosis wip Work in Progress labels Jan 18, 2023
jmederosalvarado
jmederosalvarado reviewed Jan 23, 2023
View reviewed changes
Copy link
Member

@jmederosalvarado jmederosalvarado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. I left a few comments. Apart from that, I would like to make sure that WithdrawalContractAdress allows for block => address configuration, so that we can hardfork into new withdrawal contract if needed. BlockRewardsContractAddress in chainspec already works like this, we want to replicate that functionality for withdrawals on chainspec loading.

src/Nethermind/Nethermind.Specs/ChainSpecStyle/AuRaParameters.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Specs/ChainSpecStyle/Json/ChainSpecJson.cs Outdated Show resolved Hide resolved
LukaszRozmej
LukaszRozmej requested changes Jan 31, 2023
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are modifing and adding stuff in Nethermind.Consensus.AuRa while it should be Nethermind.Merge.AuRa.

src/Nethermind/Nethermind.Consensus.AuRa/IActivatedAt.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Consensus.AuRa/Contracts/WithdrawalContract.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Consensus.AuRa/Withdrawals/WithdrawalContractFactory.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Consensus.AuRa/InitializationSteps/InitializeBlockchainAuRa.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Consensus.AuRa/Withdrawals/WithdrawalProcessor.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Consensus.AuRa/Withdrawals/WithdrawalProcessor.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Merge.AuRa/AuRaMergeBlockProducerEnvFactory.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Specs/ChainSpecStyle/AuRaParameters.cs Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Specs/ChainSpecStyle/Json/ChainSpecJson.cs Outdated Show resolved Hide resolved
@rubo
Copy link
Contributor Author

rubo commented Jan 31, 2023

You are modifing and adding stuff in Nethermind.Consensus.AuRa while it should be Nethermind.Merge.AuRa.

@LukaszRozmej What exactly should go to Nethermind.Merge.AuRa, everything?

@rubo rubo requested a review from LukaszRozmej February 1, 2023 11:55
@LukaszRozmej
Copy link
Member

@rubo I think everything, unless we need to expose something from original AuRa. Original AuRa is still in use on some networks like EWC and it doesn't have the concept of withdrawals.

@MarekM25 MarekM25 self-requested a review March 31, 2023 09:19
MarekM25
MarekM25 requested changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's resolve the last comments before merging

@rubo rubo marked this pull request as draft March 31, 2023 18:40
@rubo rubo force-pushed the feature/aura-withdrawals branch from 3228cdb to 97af58d Compare March 31, 2023 22:07
@rubo rubo marked this pull request as ready for review March 31, 2023 22:07
@rubo rubo force-pushed the feature/aura-withdrawals branch from 97af58d to 2507ef5 Compare March 31, 2023 22:10
@rubo rubo merged commit af2279c into master Apr 3, 2023
@rubo rubo deleted the feature/aura-withdrawals branch April 3, 2023 13:21
@yperbasis yperbasis mentioned this pull request May 16, 2023
Merged
yperbasis added a commit to erigontech/erigon that referenced this pull request May 16, 2023
@yperbasis
Schedule Shapella on Chiado (#7518)
ea9712f 
See NethermindEth/nethermind#5160,
NethermindEth/nethermind#5688, and
gnosischain/configs#11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmederosalvarado jmederosalvarado jmederosalvarado left review comments

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@MarekM25 MarekM25 MarekM25 approved these changes

Assignees
No one assigned
Labels
eip gnosis
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Gnosis beacon chain push withdrawals
4 participants
@rubo @LukaszRozmej @MarekM25 @jmederosalvarado