From 714e36e8bf83eae0f13ee3e46145af4973de1b59 Mon Sep 17 00:00:00 2001
From: maksadbek <a.maksadbek@gmail.com>
Date: Mon, 11 Nov 2024 11:55:49 +0100
Subject: [PATCH] ci: fix node20 compatibility issues in e2e pipeline (#606)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

e2e pipeline fails on Ubuntu 16.04 and 18.04 due to the recent default
switch to node20 in actions/checkout. Node20 requires GLIBC 2.28 or
higher, which these environments lack. To resolve this, we’re setting
the `ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true` environment variable
to allow fallback to a compatible Node version, restoring pipeline
stability.

Useful links:
* [GitHub changelog: node20
default](https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/)
* [GitHub issue #1809](https://github.com/actions/checkout/issues/1809)
---
 .github/workflows/e2e.yml | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
index 94bc2ebb..d9c1a04b 100644
--- a/.github/workflows/e2e.yml
+++ b/.github/workflows/e2e.yml
@@ -41,6 +41,9 @@ jobs:
     if: ${{ inputs.test-executables }}
     runs-on: ${{ matrix.os }}
     container: ${{ matrix.container }}
+    env:
+      ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
+
     strategy:
       fail-fast: false
       matrix:
@@ -125,6 +128,7 @@ jobs:
           E2E_REPEATER_TARGET_URL: ${{ format('http://localhost:{0}', steps.target.outputs.port) }}
           E2E_REPEATER_TARGET_CMD: ${{ steps.target.outputs.cmd }}
           E2E_TEST_TIMEOUT: ${{ inputs.test_timeout }}
+
   msi:
     if: ${{ inputs.test-msi }}
     runs-on: windows-latest
@@ -175,6 +179,7 @@ jobs:
           E2E_REPEATER_TARGET_URL: ${{ format('http://localhost:{0}', steps.target.outputs.port) }}
           E2E_REPEATER_TARGET_CMD: ${{ steps.target.outputs.cmd }}
           E2E_TEST_TIMEOUT: ${{ inputs.test_timeout }}
+
   docker:
     if: ${{ inputs.test-docker }}
     runs-on: ${{ matrix.os }}
@@ -217,10 +222,14 @@ jobs:
           E2E_REPEATER_TARGET_URL: ${{ format('http://host.docker.internal:{0}', steps.target.outputs.port) }}
           E2E_REPEATER_TARGET_CMD: ${{ steps.target.outputs.cmd }}
           E2E_TEST_TIMEOUT: ${{ inputs.test_timeout }}
+
   npm:
     if: ${{ inputs.test-npm }}
     runs-on: ${{ matrix.os }}
     container: ${{ matrix.container }}
+    env:
+      ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
+
     strategy:
       fail-fast: false
       matrix: