Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update axe-core to latest #270

Closed
hpinkos opened this issue Jun 29, 2023 · 5 comments
Closed

Update axe-core to latest #270

hpinkos opened this issue Jun 29, 2023 · 5 comments

Comments

@hpinkos
Copy link

hpinkos commented Jun 29, 2023

I'm currently running into this bug: dequelabs/axe-core#3771

It looks like it was fixed in dequelabs/axe-core#3777 and included in the 4.5.2 release.
Can you please update your dependencies to help us fix this issue? Thanks!
@philcon93
Copy link

I'm also needing the latest axe-core in our code base, I have created a PR which would update this dependency if we could get that looked at please :)

@NickColley
Copy link
Owner

I'll update the dependencies and get a release out today since it's impacting more than one person, thanks for raising.

@NickColley
Copy link
Owner

Okay the newer version of axe fails as it's expecting the existence of canvas, so I need to determine what rule is using canvas and decide if it's worth adding this additional dependency to the instructions or by default turning off this rule.

@NickColley
Copy link
Owner

They've introduced more color checks which is disabled by default in jest-axe, so I've added functionality to find color category rules and auto disabled them by default:

21b4160

@NickColley
Copy link
Owner

Released as jest-axe version 8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NickColley @hpinkos @philcon93