Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/Remove for local styles #16

Open
Madis0 opened this issue Aug 11, 2018 · 1 comment
Open

Add/Remove for local styles #16

Madis0 opened this issue Aug 11, 2018 · 1 comment

Comments

@Madis0
Copy link
Contributor

Madis0 commented Aug 11, 2018

Why do local styles not have a button Remove?
It would also make sense to add a button Add below them, so opening the popup would not be necessary if the user doesn't want to target a specific website with the new style.

@Madis0 Madis0 changed the title Remove local styles Add/Remove for local styles Aug 11, 2018
@NiklasGollenstede
Copy link
Owner

Well, I am always reluctant when it comes to deleting files.

Removeing a remote style just deletes the link from the list of installed styes and clears some caches. The only thing that is truly lost are the user settings for that style (TODO: there should be an option for that).

For local styles the semantics would be different. In absence of backups, the style is lost permanently lost.
Putting stuff in the system trash turns out to be [stupidly complicated}(https://github.com/sindresorhus/trash).
So I guess an option to open the local dir in the systems file explorer/browser/finder/whatever would help the user to delete styles (and also be very clear about whats going on).

As mentioned before, I want to change the style adding workflow anyway. I just don't know how and when.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants