Release v1.2.3-test21 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Improve validation by introducing multiple new validation decorators
* `IsIdMap` for types of the form `{ readonly [key: UUID]: T }`. This transforms the object, so using instance objects (instead of plain objects) will no longer be supported.
* `IsLiteralUnion` for literal unions of types `number | string | symbol` (e.g. `participant | trainer`). Uses `isIn` internally.
* `IsReachableTransferPoints` for `ReachableTransferPoints` used in `TransferPoint`. Very specific but necessary due to the unique structure of this type.
* `IsUUIDSet` for `UUIDSet`
* `IsValue` for *simple* values that are required for a property. For example, when a `type` property has to have the value `'partial'`, one can use `@IsValue('partial')` for this. Allowed are the types `bigint | boolean | number | string | symbol | null | undefined`. The reason is that this validator also uses `isIn` internally, which in turn uses `===` which might produce incorrect results for `object` values.
* All validators are required to be applied to correctly types properties by the use of `GenericPropertyDecorator`. Using e.g. `@IsLiteralUnion({ partial: true, complete: true })` on a property typed `string` raises a TypeScript error.
Co-authored-by: Julian Schmidt <julian.r.schmidt.js@gmail.com>
* Move state migrations to shared * Add benchmark package * Update readmes * Make problem with duplicated RestoreError more obvious
* Disallow imports from "*/dist/*" * Improve smaller eslint rules * Update documentation
* Update dependencies * typescript@4.9 (satisfies-operator and watch-performance-improvements) * angular@15.1 * Else only patch and minor version bumps * Fix version of @types/node in benchmark and frontend (18 -> 16) * Run prettier
* Add simulated regions that can be placed on the map * Fix naming * Add migration * Fix linter error * Move simulated region to separate heading in trainer map editor * Turn isInSimulatedRegion into a stub method * Refactor ol-map-manager to reuse some features from viewport in simulatedRegion
* Rename VS Code configs to `.example` * Add new "Start all but database" task * Explain changes in readme
* Instead of using some parts of the `Modify` interaction (side-effect in the style function) a new custom Interaction has been created. * Previously, one could switch between resizing and translating a viewport via pressing `Shift`. Instead, now one ***resizes*** if one drags an edge of the viewport (+ a bit around it), and ***translates*** if one drags any other part. This should enable touch users to resize viewports * The code should now be more readable and extendable * The unnecessary `viewportTranslateInteraction` has been removed * `feature.dispose()` now gets called when it gets deleted - this could have been a memory leak?
* Add keydown handler to close popups on escape * Ensure input is saved even after less than 600ms * Cast event inline Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de>
* Add new image for big material and material Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de>
* Add MetaPosition type * Add MetaPosition to Vehicle * Add MetaPosition ro Personnel * Add MetaPosition to Material * Add MetaPosition to Patient * Add Classes for different Position Types * Use create when applicable and fix in MetaPosition * Add migration for addition of MetaPosition * refactor literals to start with lowercase * Change nested if else to else if * Make metaPosition not optional * Fix failing Tests * Update shared/src/models/material.ts Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de> * Update shared/src/models/patient.ts Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de> * Update shared/src/models/personnel.ts Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de> * Update shared/src/store/action-reducers/patient.ts Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de> * Update shared/src/store/action-reducers/utils/calculate-treatments.spec.ts Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de> * Update shared/src/store/action-reducers/vehicle.ts Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de> * Fix Prettier Errors * Change Validation to Allow * Put personnel and material in vehicle on creation * Update shared/src/store/action-reducers/transfer.ts Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de> * Fix Pipeline dependencies * Update shared/src/state-migrations/16-add-meta-position.ts Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de> * Fix linter Error * Add validators to MetaPositions * Remove unused imports * Fix Validators * Add/Fix Action Migrations * Add Exports to Index.ts * Update shared/src/store/action-reducers/utils/spatial-elements.ts Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de> * Update shared/src/store/action-reducers/vehicle.ts Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de> * Fix Lint Co-authored-by: Nils <45318774+Nils1729@users.noreply.github.com> Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de>
…xercise (hpi-sam#622) * Fixes "Features disappear from the map in imported exercises" hpi-sam#621 * Can be observed when two actions are simultaneously optimistically proposed, and the client didn't receive any other action from the server before
…pi-sam#624) * Fix incorrect import of isEmpty This caused "Patients are automatically triaged without any personnel on the map" hpi-sam#623 * Disallow isEmpty imports from class-validator via eslint
…Unfall-Hilfe e.V. (JUH) (hpi-sam#619) * Add Image for Johanniter Akademie NRW, Campus Münster der Johanniter-Unfall-Hilfe e.V. (JUH) * Fix linter * Mention JUH in Readme * Scale down the malteser logo and add the new 22/23 project team to the landing page * Add our year to the landing page
* Refactor viewports and simulated regions to be polygons instead of lines * Add opaque fill to simulated regions * Fix linter * WIP * Refactor Coordinates and Points to Compositions * Update readme accordingly * Change default type of SubstituteCoordinateForPoint to never as it should never happen * Fix typo * Increase alpha value to 80% * Fix bug where features did not sync their movement to other clients * Fix linter * Refactor lambda function to geometry helpers and refactor ElementFeature ElementFeature (which had to extend Feature<FeatureType>) has been replaced by Feature<FeatureType> because according to ol docs there are no classes extending Feature * Remove ElementManager.recreateFeature() * Refactor lambdas to function in Geometry Helper subclasses * Rename getNextPosition to interpolateCoordinates * Refactor polygon geometry helper names in map lambda function * Remove comment and type cast Co-authored-by: Julian Schmidt <julian.r.schmidt.js@gmail.com>
* WIP * Pick specific selectors from TypeSelectorMap * Fix linter * Remove type property from feature * Fix bug after merge * Rename selector map to plural map and add validation * Simplify featureKeys * Fix tests by adding type property to demo objects * WIP: Add migration * Update shared/src/utils/type-state-selector-map.ts Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de> * Rename file to reflect variable name change * Replace type literals by element property * Run prettier * Finish migration * Fix migration to set correct type on EocLogEntry * Make imports consistent * Reuse literal union from transfer in exercise * Fix linter Co-authored-by: Julian Schmidt <julian.schmidt@student.hpi.de>
…ry (hpi-sam#634) * Remove generic type LineString | Point in favor of the default Geometry * Fix linter
* Add MetaPosition Helpers * Remove position property * Fix Lint * Unify access onto metaPosition * Fix Frontend * Remove Position Class * Remove Position from Tests * Rename MetaPosition to Position * Add Migration (not for Add vehicle Action) * complete the renaming * Fix Tests * Remove Transfer Property * Add Migration for Add Vehicle Action * Fix Small Bug * Use type properties instead of passed strings * Add comments * Fix Test * Fix Test * Fix Transfer Overview * Refactor Helper Methods to avoid duplicate Code * Change Names of Helper Functions * Added Comments to unused vars
* Allow elements to be added to simulated regions * Adapt Add to Simulated Region Action to type tags * Make linter happy * Use new position and bugfixes * Use proper function to create position
* Refactor Start Point Literals * Add Migration * Enable Migration * Implement Feedback * Remove not needed types
* Add basic footer and empty about pages * Refactor structure of about pages * Add footer to 404 page * Add links from footer to exercise page * Run prettier * Display version number * Explain overwriting the pages in Docker deployment * Do not lint HTML files for about pages * Refactor template component * Rename title property since it's an html attribute * Make content observable * Rename template component Avoids confusion with angular concepts * Remove accidentally committed imprint dummy file * Remove commented-out footer from exercise page
* Make Map movable on Drag with Pop Up
* Update pipeline actions to node 16 The old actions were based on Node 12, which has reached EOL. https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ * Test previous version of cypress action again * Try cypress action v3 * Do not use cached cypress * Try a Cypress Config without actually calling Cypress * Try some more stuff... * Add Cypress as DevDependency to root * Re-enable default cypress tests * Remove version tag from cypress cache The tag was there for debugging purposes only * Invoke cypress in frontend subfolder * Try working-directory for cypress * Try --prefix for start * Retry --prefix before 'run' * Restore 5a9692d * Update package-lock.json --------- Co-authored-by: ClFeSc <68013019+ClFeSc@users.noreply.github.com> Co-authored-by: Nils <45318774+Nils1729@users.noreply.github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
Co-authored-by: GitHub Actions <noreply@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was created in response to a running workflow.
I've updated the version name and changelog: b4f7cf9