Refactor unix domain socket store config #11109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following what is outlined in NixOS#10766 refactor the uds-remote-store such that the member variables (state) don't live in the store itself but in the config object. Additionally, the config object includes a new necessary constructor that takes a scheme & authority. Minor: * code formatting * cleanup of getting default path * added some comments
github-actions
bot
added
the
store
Ericson2314
reviewed
Jul 15, 2024
Co-authored-by: John Ericson <git@JohnEricson.me>
Ericson2314
reviewed
Jul 15, 2024
Ericson2314
reviewed
Jul 15, 2024
Ericson2314
requested changes
Jul 15, 2024
There was a problem hiding this comment.
It would be good to have a unit test like #11108, very close otherwise! :)
Revert back to basic constructor in store-api.cc Co-authored-by: John Ericson <git@JohnEricson.me>
Ericson2314
reviewed
Jul 15, 2024
|
Failing MacOS builds but not sure why -- appreciate any pointer. |
Ericson2314
reviewed
Jul 16, 2024
Hopefully this fixes the macOS link error. It's also good for compilation time.
Ericson2314
approved these changes
Jul 16, 2024
Ericson2314
changed the title
auto-merge was automatically disabled
July 16, 2024 12:47
Head branch was pushed to by a user without write access
Not having these causes some issues with the new unit tests.
This reverts commit c4c148f.
…o issue-10766-unix-socket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Following what is outlined in #10766 refactor the uds-remote-store such that the member variables (state) don't live in the store itself but in the config object.
Additionally, the config object includes a new necessary constructor that takes a scheme & authority.
Minor:
Context
Please see #10766
This adds part of the work for the unix domain socket store.
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.