Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move uriSchemes to *StoreConfig #11112

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Jul 16, 2024

Motivation

It is a property of the configuration of a store --- how a store URL is parsed into a store config, not a store itself.

Context

Progress towards #10766

Depends on #11109

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@Ericson2314 Ericson2314 requested a review from edolstra as a code owner July 16, 2024 03:45
@github-actions github-actions bot added the store Issues and pull requests concerning the Nix store label Jul 16, 2024
Copy link

dpulls bot commented Jul 18, 2024

🎉 All dependencies have been resolved !

Copy link
Contributor

@fzakaria fzakaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It is a property of the configuration of a store --- how a store URL is
parsed into a store config, not a store itself.

Progress towards NixOS#10766
@Ericson2314 Ericson2314 enabled auto-merge July 18, 2024 03:48
@Ericson2314 Ericson2314 disabled auto-merge July 18, 2024 03:48
@Ericson2314 Ericson2314 enabled auto-merge July 18, 2024 03:49
@Ericson2314 Ericson2314 merged commit 606ace4 into NixOS:master Jul 18, 2024
10 checks passed
@Ericson2314 Ericson2314 deleted the move-schemes-set branch July 18, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
store Issues and pull requests concerning the Nix store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants