Add unit tests for xml-writer #3625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add unit tests for
xml-writer.ccNotes:
Small surface and just some basic tests to establish/document functionality. I did notice one thing though:
When providing attributes <key,value> only the value is escaped, the key isn't.
Meaning it's possible to write invalid xml. I'll let the unit test encode the current state and open an issue when this is merged. Fixing this inFrom what I can tell attribute names cannot be escaped so this would have to throw instead.XMLWriter::writeAttrs(const XMLAttrs & attrs)should be easy enough and I can do that as a follow-up.