Add unit tests for config.cc #3631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves the actual parsing of configuration contents into applyConfig which applyConfigFile is then going to call. By changing this we can now test the configuration file parsing without actually create a file on disk.
Provides some general overview on the mechanics of Config/Setting and comments for the public methods of Config.
andir
force-pushed
the
libutil-config-tests
branch
from
c375948 to
fc137d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds unit tests for
libutil/config.{hh,cc}, particularly theConfigclass and it's interaction withSetting. Since initially it had been a bit confusing howSettingandConfiginteract there are now a few additional comments in the header file.In order to test the configuration file parsing (without solving the cross-platform temporary file problem) I had to do a minor refactoring of the
Config::applyConfigFilemethod. The part that actually operates on the contents of the string has been factored out and is being tested with some basic examples. Actual testing with configuration files is still desirable but that is being done by the other (functional) tests.While the tests cover most of the methods there is probably still room for improvement. I couldn't figure out how to test things like
warnUnkownSettings(output capturing isn't supported by GTest and redirecting FDs didn't feel right) orreapplyUnknownSettings(see FIXME comments in the Diff).