From d34d5280d16cadd203685497c7a5f5aeb992fce1 Mon Sep 17 00:00:00 2001 From: Bryan Lai Date: Wed, 28 Feb 2024 12:40:39 +0800 Subject: [PATCH 1/2] python2Packages.wcwidth: fix build As of version 0.2.13 upstream still supports python2. In the future, this package should be dropped or pinned to the last working version after the final release for python2. --- pkgs/development/python2-modules/wcwidth/default.nix | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/pkgs/development/python2-modules/wcwidth/default.nix b/pkgs/development/python2-modules/wcwidth/default.nix index 023b92a869071..87d3f3848da17 100644 --- a/pkgs/development/python2-modules/wcwidth/default.nix +++ b/pkgs/development/python2-modules/wcwidth/default.nix @@ -6,5 +6,12 @@ wcwidth.overridePythonAttrs(oldAttrs: { propagatedBuildInputs = oldAttrs.propagatedBuildInputs or [] ++ [ backports-functools-lru-cache ]; -}) + /** + As of version 0.2.13 upstream still supports python2. In the future, this + package should be dropped or pinned to the last working version after the + final release for python2. See: + https://github.com/jquast/wcwidth/pull/117#issuecomment-1946609638 + */ + disabled = false; +}) From 5ebb67ecc9c23648876c092224ea2f4702730bdc Mon Sep 17 00:00:00 2001 From: Bryan Lai Date: Mon, 11 Mar 2024 23:35:39 +0800 Subject: [PATCH 2/2] python2Packages.wcwidth: @bryango in maintainers Add myself in maintainers, and make sure that python3 maintainers is _not_ pinged for python2 issues. --- pkgs/development/python2-modules/wcwidth/default.nix | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkgs/development/python2-modules/wcwidth/default.nix b/pkgs/development/python2-modules/wcwidth/default.nix index 87d3f3848da17..eccaadf66c54f 100644 --- a/pkgs/development/python2-modules/wcwidth/default.nix +++ b/pkgs/development/python2-modules/wcwidth/default.nix @@ -1,5 +1,6 @@ { backports-functools-lru-cache , wcwidth +, lib }: wcwidth.overridePythonAttrs(oldAttrs: { @@ -14,4 +15,10 @@ wcwidth.overridePythonAttrs(oldAttrs: { https://github.com/jquast/wcwidth/pull/117#issuecomment-1946609638 */ disabled = false; + + meta = oldAttrs.meta // { + /** maintainers overridden here for python2; this makes sure that python3 + maintainers are not blamed for the breakage here. */ + maintainers = with lib.maintainers; [ bryango ]; + }; })