-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixosTests.timezone fails on master: static timezone can be interactively changed when it shouldn't #224080
Comments
Regression introduced in #221461. |
it'd be nice to have more context in either bug reports or the nixosTests themselves. I had to kind of reverse engineer that the test wants for So, the way I understand we want to reintroduce the patch that denies the set-timezone call in timedated, right? |
I checked our old patch again: https://github.com/NixOS/nixpkgs/pull/216826/files#diff-0318a6cd550cf991c6c8b82ead9134f45dadc8b9e8532a724768695ab4789739L79 In NixOS, We have some corner cases where we do allow some of these things to be mutable:
We previously disallowed setting machine info, locale, vc/x11 keyboard, Some of this patch might even not need to be patched in, but we should check if upstream fails with a useful-enough error message (#80038). @gdamjan happy to take a look at this next week. |
I took a closer look. In case We need to keep the patch disallowing |
…t-cha.patch In NixOS, /etc is NOT read-only, and most things in /etc are symlinks to /etc/static, which is a symlink into the nix store - so the upstream systemd "/etc is read-only" detection doesn't work. Fixes NixOS#224080.
This was fixed in #226192, which was merged to staging and will or already did end up in master. Let's close this issue, there's nothing left to be done here. |
Steps To Reproduce
Steps to reproduce the behavior:
nixosTests.timezone
Build log
Notify maintainers
@lheckemann
Metadata
x86_64-linux, 5d154ce
The text was updated successfully, but these errors were encountered: