Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdirsyncer: deprecate vdirsyncerStable #103073

Merged
merged 3 commits into from
Nov 16, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 12 additions & 57 deletions pkgs/development/python-modules/vdirsyncer/default.nix
Original file line number Diff line number Diff line change
@@ -1,52 +1,29 @@
{ stdenv
, buildPythonPackage
, fetchFromGitHub
, fetchPypi
, isPy27
, fetchpatch
, rustPlatform
, pkg-config
, openssl
, CoreServices
, Security
, click
, click-log
, click-threading
, requests_toolbelt
, requests
, requests_oauthlib # required for google oauth sync
, atomicwrites
, milksnake
, shippai
, hypothesis
, pytest
, pytestCheckHook
, pytest-localserver
, pytest-subtesthack
, setuptools_scm
}:

# Packaging documentation at:
# https://github.com/untitaker/vdirsyncer/blob/master/docs/packaging.rst
buildPythonPackage rec {
version = "unstable-2018-08-05";
version = "0.16.8";
pname = "vdirsyncer";
name = "${pname}-${version}";
disabled = isPy27;

src = fetchFromGitHub {
owner = "spk";
repo = pname;
# fix-build-style branch, see https://github.com/pimutils/vdirsyncer/pull/798
rev = "2c62d03bd73f8b44a47c2e769ade046697896ae9";
sha256 = "1q6xvzz5rf5sqdaj3mdvhpgwy5b16isavgg7vardgjwqwv1yal28";
};

native = rustPlatform.buildRustPackage {
name = "${name}-native";
inherit src;
sourceRoot = "source/rust";
cargoSha256 = "0cqy0s55pkg6hww86h7qip4xaidh6g8lcypdj84n2x374jq38c5d";
nativeBuildInputs = [ pkg-config ];
buildInputs = [ openssl ] ++ stdenv.lib.optionals stdenv.isDarwin [ CoreServices Security ];
src = fetchPypi {
inherit pname version;
sha256 = "bfdb422f52e1d4d60bd0635d203fb59fa7f613397d079661eb48e79464ba13c5";
};

propagatedBuildInputs = [
Expand All @@ -55,8 +32,6 @@ buildPythonPackage rec {
requests
requests_oauthlib # required for google oauth sync
atomicwrites
milksnake
shippai
];

nativeBuildInputs = [
Expand All @@ -65,45 +40,25 @@ buildPythonPackage rec {

checkInputs = [
hypothesis
pytest
pytestCheckHook
pytest-localserver
pytest-subtesthack
];

patches = [
(fetchpatch {
url = "https://github.com/pimutils/vdirsyncer/commit/7b636e8e40d69c495901f965b9c0686513659e44.patch";
sha256 = "0vl942ii5iad47y63v0ngmhfp37n30nxyk4j7h64b95fk38vfwx9";
})
];

postPatch = ''
# see https://github.com/pimutils/vdirsyncer/pull/805
substituteInPlace setup.cfg --replace --duration --durations

# for setuptools_scm:
echo 'Version: ${version}' >PKG-INFO

sed -i 's/spec.add_external_build(cmd=cmd/spec.add_external_build(cmd="true"/g' setup.py

# fixing test
sed -i "s/invalid value for \"--verbosity\"/invalid value for \\\'--verbosity\\\'/" tests/system/cli/test_sync.py
substituteInPlace setup.py --replace "click>=5.0,<6.0" "click"
'';

preBuild = ''
mkdir -p rust/target/release
ln -s ${native}/lib/libvdirsyncer_rustext* rust/target/release/
preCheck = ''
export DETERMINISTIC_TESTS=true
'';

checkPhase = ''
rm -rf vdirsyncer
make DETERMINISTIC_TESTS=true PYTEST_ARGS="--deselect=tests/unit/utils/test_vobject.py::test_replace_uid --deselect=tests/unit/sync/test_sync.py::TestSyncMachine" test
'';
disabledTests = [ "test_verbosity" ];

meta = with stdenv.lib; {
homepage = "https://github.com/pimutils/vdirsyncer";
description = "Synchronize calendars and contacts";
maintainers = with maintainers; [ matthiasbeyer gebner ];
license = licenses.mit;
maintainers = with maintainers; [ loewenheim ];
};
}
64 changes: 0 additions & 64 deletions pkgs/development/python-modules/vdirsyncer/stable.nix

This file was deleted.

1 change: 1 addition & 0 deletions pkgs/top-level/aliases.nix
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,7 @@ mapAliases ({
v8_3_16_14 = throw "v8_3_16_14 was removed in 2019-11-01: no longer referenced by other packages";
valadoc = throw "valadoc was deprecated on 2019-10-10: valadoc was merged into vala 0.38";
vamp = { vampSDK = vamp-plugin-sdk; }; # added 2020-03-26
vdirsyncerStable = vdirsyncer; # added 2020-11-08, see https://github.com/NixOS/nixpkgs/issues/103026#issuecomment-723428168
magnetophon marked this conversation as resolved.
Show resolved Hide resolved
vimbWrapper = vimb; # added 2015-01
vimprobable2 = throw "vimprobable2 has been removed from nixpkgs. It relied on webkitgtk24x that has been removed."; # added 2019-12-05
vimprobable2-unwrapped = vimprobable2; # added 2019-12-05
Expand Down
2 changes: 0 additions & 2 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -24034,8 +24034,6 @@ in

vdirsyncer = with python3Packages; toPythonApplication vdirsyncer;

vdirsyncerStable = with python3Packages; toPythonApplication vdirsyncerStable;

vdpauinfo = callPackage ../tools/X11/vdpauinfo { };

verbiste = callPackage ../applications/misc/verbiste {
Expand Down
7 changes: 1 addition & 6 deletions pkgs/top-level/python-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -7483,12 +7483,7 @@ in {

vdf = callPackage ../development/python-modules/vdf { };

vdirsyncer = callPackage ../development/python-modules/vdirsyncer {
inherit (pkgs.darwin.apple_sdk.frameworks) CoreServices Security;
inherit (pkgs) pkg-config openssl rustPlatform;
};

vdirsyncerStable = callPackage ../development/python-modules/vdirsyncer/stable.nix { };
vdirsyncer = callPackage ../development/python-modules/vdirsyncer { };

vega = callPackage ../development/python-modules/vega { };

Expand Down