Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since #103073 the hydra build of vdirsyncer was broken.
Disables sync_test:test_create_collection, a flaky test which exceeds its
deadline and breaks the build on hydra, e.g this hydra build log
Upstream vdirsyncer issue: pimutils/vdirsyncer#837
Since things seem to work for most people, my guess is that it works on beefier machines than my laptop or the hydra builder. I don't know if there is some way to increase the test timeout easily or if this is actually some performance regression.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review rev fixVdirsyncerTest"
./result/bin/
)nix path-info -S
before and after)