bazel_4: 4.0.0 -> 4.1.0 #123895

dmivankov · 2021-05-21T12:45:20Z

https://github.com/bazelbuild/bazel/releases/tag/4.1.0

other minor changes:

grep for /bin/ rather than /bin for blanket substitute
invoke {pre,post}{Build,Install} hooks

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Added a release notes entry if the change is major or breaking
Fits CONTRIBUTING.md.

r-rmcgibbo · 2021-05-21T14:04:31Z

Result of nixpkgs-review pr 123895 at 3e965a42 run on x86_64-linux 1

1 package built successfully:

bazel_4

20 suggestions:

warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/true' doesn't match anything in file 'src/main/java/com/google/devtools/build/lib/shell/Command.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/usr/bin/env' doesn't match anything in file 'src/main/java/com/google/devtools/build/docgen/templates/be/make-variables.vm'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/usr/bin/env bash' doesn't match anything in file 'src/main/java/com/google/devtools/build/docgen/PredefinedAttributes.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/usr/bin/env bash' doesn't match anything in file 'src/main/java/com/google/devtools/build/docgen/templates/be/make-variables.vm'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/usr/bin/env python' doesn't match anything in file 'src/main/java/com/google/devtools/build/lib/sandbox/DarwinSandboxedSpawnRunner.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: missing-phase-hooks
installPhase should probably contain runHook preInstall and runHook postInstall.

Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:572:3:
```
    |
572 |   installPhase = ''
    |   ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/main/java/com/google/devtools/build/docgen/PredefinedAttributes.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/main/java/com/google/devtools/build/lib/sandbox/DarwinSandboxedSpawnRunner.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/true' doesn't match anything in file 'src/main/java/com/google/devtools/build/docgen/PredefinedAttributes.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/usr/bin/env bash' doesn't match anything in file 'src/main/java/com/google/devtools/build/lib/sandbox/DarwinSandboxedSpawnRunner.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/usr/bin/env bash' doesn't match anything in file 'src/main/java/com/google/devtools/build/lib/shell/Command.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/main/java/com/google/devtools/build/docgen/templates/be/make-variables.vm'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/usr/bin/env' doesn't match anything in file 'src/main/java/com/google/devtools/build/lib/shell/Command.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/true' doesn't match anything in file 'src/main/java/com/google/devtools/build/docgen/templates/be/make-variables.vm'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: missing-phase-hooks
buildPhase should probably contain runHook preBuild and runHook postBuild.

Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:542:3:
```
    |
542 |   buildPhase = ''
    |   ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/usr/bin/env python' doesn't match anything in file 'src/main/java/com/google/devtools/build/docgen/PredefinedAttributes.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/usr/bin/env python' doesn't match anything in file 'src/main/java/com/google/devtools/build/docgen/templates/be/make-variables.vm'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/bin/bash' doesn't match anything in file 'src/main/java/com/google/devtools/build/lib/shell/Command.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/usr/bin/env python' doesn't match anything in file 'src/main/java/com/google/devtools/build/lib/shell/Command.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```
warning: stale-substitute
Stale substituteInPlace detected.
substituteStream(): WARNING: pattern '/usr/bin/env' doesn't match anything in file 'src/main/java/com/google/devtools/build/docgen/PredefinedAttributes.java'
Near pkgs/development/tools/build-managers/bazel/bazel_4/default.nix:170:0:
```
    |
170 |     description = "Build tool that builds code quickly and reliably";
    | ^
```

dmivankov · 2021-05-21T14:06:55Z

Interesting suggestions about unused substitutions, will try to have a look

jonringer · 2021-05-21T23:44:59Z

If they are being blanket applied across a host of files, I would say you can pass over the suggestions. But some of them may warrant investigation.

uri-canva · 2021-05-22T05:44:35Z

Tested on macOS, works.

https://github.com/bazelbuild/bazel/releases/tag/4.1.0 other minor changes: - grep for /bin/ rather than /bin for blanket substitute - invoke {pre,post}{Build,Install} hooks

dmivankov · 2021-05-22T08:12:36Z

Had a quick look into suggestions:

added pre/post hooks invocations
changed grep /bin with grep /bin/
some unused substitutions are false positive and/or about /bin/ mentioned in comments/docs
in bazel source code there seems to be more (/usr)/bin/ references, but hard to tell if it is an issue or changed since 3.7 or 4.0
especially unclear with getconf on darwin, so let's maybe rely on tests & user tests for now

timothyklim · 2021-05-23T15:41:59Z

Please, include patch for bazel-toolchains bazelbuild/bazel#13099 (comment)

dmivankov · 2021-05-25T09:15:20Z

@timothyklim not very familiar with code around that patch

does it change packaged bazel binary?
is it to be applied to user WORKSPACE files only?

My first impression is that users simply need to use patched/suitable bazel-toolchains with bazel-4.1.0 and bazel itself can't be patched to be compatible with older versions. So unless we hit an issue compiling bazel 4.1..0 with bazel 4.1.0 (&rbe?) all should be fine?

uri-canva · 2021-05-27T03:23:45Z

Please, include patch for bazel-toolchains

I'd rather it wasn't included: nixpkgs bazel behaving differently from upstream makes debugging issues with it harder, and makes discussions amongst the broader bazel community less applicable.

uri-canva · 2021-05-31T23:23:34Z

ping @mboes @Profpatsch

dmivankov · 2021-06-01T05:27:54Z

fwiw, using 4.1.0 from PR works fine for me so far on NixOS

github-actions · 2021-06-01T16:03:14Z

Successfully created backport PR #125246 for release-21.05.

dmivankov requested a review from Profpatsch as a code owner May 21, 2021 12:45

ofborg bot requested a review from mboes May 21, 2021 12:55

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 21, 2021

dmivankov force-pushed the bazel_4.1.0 branch from 3e965a4 to dcb3c4a Compare May 22, 2021 07:45

bazel_4: 4.0.0 -> 4.1.0

a15204f

https://github.com/bazelbuild/bazel/releases/tag/4.1.0 other minor changes: - grep for /bin/ rather than /bin for blanket substitute - invoke {pre,post}{Build,Install} hooks

dmivankov force-pushed the bazel_4.1.0 branch from dcb3c4a to a15204f Compare May 22, 2021 08:08

SuperSandro2000 added the backport release-21.05 label Jun 1, 2021

SuperSandro2000 merged commit 3bb2774 into NixOS:master Jun 1, 2021

github-actions bot mentioned this pull request Jun 1, 2021

[Backport release-21.05] bazel_4: 4.0.0 -> 4.1.0 #125246

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bazel_4: 4.0.0 -> 4.1.0 #123895

bazel_4: 4.0.0 -> 4.1.0 #123895

dmivankov commented May 21, 2021 •

edited

Loading

r-rmcgibbo commented May 21, 2021

dmivankov commented May 21, 2021

jonringer commented May 21, 2021

uri-canva commented May 22, 2021

dmivankov commented May 22, 2021 •

edited

Loading

timothyklim commented May 23, 2021

dmivankov commented May 25, 2021

uri-canva commented May 27, 2021

uri-canva commented May 31, 2021

dmivankov commented Jun 1, 2021

github-actions bot commented Jun 1, 2021

bazel_4: 4.0.0 -> 4.1.0 #123895

bazel_4: 4.0.0 -> 4.1.0 #123895

Conversation

dmivankov commented May 21, 2021 • edited Loading

Motivation for this change

Things done

r-rmcgibbo commented May 21, 2021

dmivankov commented May 21, 2021

jonringer commented May 21, 2021

uri-canva commented May 22, 2021

dmivankov commented May 22, 2021 • edited Loading

timothyklim commented May 23, 2021

dmivankov commented May 25, 2021

uri-canva commented May 27, 2021

uri-canva commented May 31, 2021

dmivankov commented Jun 1, 2021

github-actions bot commented Jun 1, 2021

dmivankov commented May 21, 2021 •

edited

Loading

dmivankov commented May 22, 2021 •

edited

Loading