Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gxplugins-Lv2: 0.8 -> 0.9 #124066

Merged
merged 1 commit into from
May 30, 2021
Merged

Gxplugins-Lv2: 0.8 -> 0.9 #124066

merged 1 commit into from
May 30, 2021

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented May 22, 2021

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels May 22, 2021
@r-rmcgibbo
Copy link

Result of nixpkgs-review pr 124066 at 3a46c41f run on x86_64-linux 1

1 package built successfully:
  • gxplugins-lv2
2 suggestions:
  • warning: unclear-gpl

    gpl3 is a deprecated license, please check if project uses gpl3Plus or gpl3Only and change meta.license accordingly.

    Near pkgs/applications/audio/gxplugins-lv2/default.nix:32:5:

       |
    32 |     license = licenses.gpl3;
       |     ^
    
  • warning: missing-phase-hooks

    configurePhase should probably contain runHook preConfigure and runHook postConfigure.

    Near pkgs/applications/audio/gxplugins-lv2/default.nix:22:3:

       |
    22 |   configurePhase = ''
       |   ^
    

@github-actions
Copy link
Contributor

Successfully created backport PR #124937 for release-21.05.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants