Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.taffybar: override src until next Hackage update #124099

Merged
merged 1 commit into from
May 23, 2021

Conversation

rvl
Copy link
Contributor

@rvl rvl commented May 23, 2021

Motivation for this change

Taffybar 3.2.5 fixes dyre compatibility, but is not in Hackage as of 2021-05-19T07:17:55Z.

To be merged into #123682.

cc @IvanMalison @cdepillabout

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Added a release notes entry if the change is major or breaking
  • Fits CONTRIBUTING.md.

Taffybar 3.2.5 fixes dyre compatibility, but is not in
Hackage as of 2021-05-19T07:17:55Z.
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 23, 2021
@colonelpanic8
Copy link
Contributor

It should be in hackage, maybe I messed up the upload?

@colonelpanic8
Copy link
Contributor

Oh I see it needed to be in the relevant hackage snapshot. Okay, looks good to me!

@cdepillabout
Copy link
Member

Looks good, thanks for updating this!

@cdepillabout cdepillabout merged commit d662775 into NixOS:haskell-updates May 23, 2021
@rvl
Copy link
Contributor Author

rvl commented May 23, 2021

Yeah, I wasn't sure whether to add an override like this or to bump the pinned hackage version and regenerate.
But I think the latter could cause new build errors, and then we would never get the haskell-updates PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: haskell 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants