Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovide: fix darwin build #145526

Closed
wants to merge 1 commit into from
Closed

neovide: fix darwin build #145526

wants to merge 1 commit into from

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Nov 11, 2021 •
edited
Loading

Motivation for this change

Closes #145523

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Nov 11, 2021
@Artturin Artturin mentioned this pull request Nov 11, 2021
Closed
@ofborg ofborg bot requested a review from ck3d November 11, 2021 18:44
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 11, 2021
@Artturin Artturin closed this Nov 12, 2021
@Artturin Artturin deleted the neovidedarwin branch November 12, 2021 14:45
@ck3d ck3d mentioned this pull request Apr 16, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer Awaiting requested review from jonringer

@teto teto Awaiting requested review from teto

@ck3d ck3d Awaiting requested review from ck3d

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Neovide fails to build on aarch64-darwin
1 participant
@Artturin