Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovide: 2022-02-04 -> 0.8.0 #168770

Merged
merged 2 commits into from
Apr 16, 2022
Merged

neovide: 2022-02-04 -> 0.8.0 #168770

merged 2 commits into from
Apr 16, 2022

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented Apr 15, 2022 •
edited
Loading

Description of changes

Update Neovide to a released version.

If you test this version of neovide, please run NixOS unstable to avoid following issue #168769

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ck3d ck3d requested review from jonringer and teto as code owners April 15, 2022 09:32
@teto
Copy link
Member

teto commented Apr 15, 2022

works here but the CI fails on darwin.

@SuperSandro2000
Copy link
Member

If you test this version of neovide, please run NixOS unstable to avoid following issue #168769

You also need a new libGL library just for neovide.

SuperSandro2000
SuperSandro2000 reviewed Apr 16, 2022
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add Security to buildInputs just for darwin? https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/haxe/default.nix#L46=

@ck3d
Copy link
Contributor Author

ck3d commented Apr 16, 2022

It is not easy to add Darwin support:
#146052
#145526

Since every failed, I will remove Darwin from supported platform.

@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Apr 16, 2022
@teto
Copy link
Member

teto commented Apr 16, 2022

since neovide is broken on unstable apparently and darwin is not straightforward, we should not put the burden on the current maintainer, if a darwin user wants to comaintain it, fine meanwhile let's merge this.

@SuperSandro2000 SuperSandro2000 merged commit 2833064 into NixOS:master Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@jonringer jonringer Awaiting requested review from jonringer

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
6.topic: vim 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ck3d @teto @SuperSandro2000