Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.uamqp: use openssl on darwin-aarch64 #175161

Merged
merged 1 commit into from
May 30, 2022

Conversation

risicle
Copy link
Contributor

@risicle risicle commented May 28, 2022

Description of changes

Azure's libraries aren't happy enough with our macos sdk on aarch64 to let us use applessl.

This is a bit of a hack, so I'd rather stick with applessl on x86_64, where we can get it to work. But I see this as a better situation for a platform where uamqp won't currently build at all.

ZHF: #172160

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.05 Release Notes (or backporting 21.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label May 28, 2022
@ofborg ofborg bot requested a review from mwilsoncoding May 28, 2022 17:31
@risicle risicle marked this pull request as ready for review May 28, 2022 17:33
@risicle risicle requested review from FRidh and jonringer as code owners May 28, 2022 17:33
@SuperSandro2000
Copy link
Member

@ofborg build python3Packages.uamqp

@SuperSandro2000
Copy link
Member

Did you test this on real hardware?

@risicle
Copy link
Contributor Author

risicle commented May 29, 2022

Yes

azure's libraries aren't happy enough with our macos sdk on aarch64
to let us use applessl
@github-actions
Copy link
Contributor

Successfully created backport PR #175533 for release-22.05.

@vcunat
Copy link
Member

vcunat commented Apr 26, 2023

I think this is the part which now started to fail with -Werror,-Wdeprecated-declarations (on aarch64-darwin only; not sure what exactly triggered the change)
https://hydra.nixos.org/build/217151025#tabs-buildsteps

/cc PR #226795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants