Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtk: switch to vtk_9 #178367

Closed
wants to merge 2 commits into from
Closed

vtk: switch to vtk_9 #178367

wants to merge 2 commits into from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jun 20, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@veprbl
Copy link
Member Author

veprbl commented Jun 21, 2022

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from matthuszagh June 23, 2022 13:39
@bcdarwin
Copy link
Member

bcdarwin commented Sep 7, 2022

It seems libX11 and libGL should be propagated from vtk_9 since in my experiments, any package depending on vtk_9 (but not vtk_8) without these inputs will fail during cmakeConfigurePhase. (f3d being a typical example.)

@veprbl
Copy link
Member Author

veprbl commented Sep 7, 2022

@bcdarwin Thanks for the tip!

@wegank
Copy link
Member

wegank commented Nov 30, 2022

@ofborg eval

@wegank
Copy link
Member

wegank commented Nov 30, 2022

@veprbl Is this PR good to merge? Got #203386 using vtk_9 with Python support here.

@veprbl
Copy link
Member Author

veprbl commented Nov 30, 2022

Needs more work. Minimal option is to pin all the broken software to vtk_8.

@wegank
Copy link
Member

wegank commented Jan 26, 2023

Needs more work. Minimal option is to pin all the broken software to vtk_8.

Done in #212455.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants