Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neovide: 0.8 -> 0.9 #179706

Merged
merged 1 commit into from
Jul 1, 2022
Merged

neovide: 0.8 -> 0.9 #179706

merged 1 commit into from
Jul 1, 2022

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented Jun 30, 2022

Description of changes

Update to latest release

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ck3d ck3d requested review from jonringer and teto as code owners June 30, 2022 12:31
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jun 30, 2022
@teto
Copy link
Member

teto commented Jun 30, 2022

compiles and works ok on my side, I ' ll leave some time for others to test.

@pmiddend
Copy link
Contributor

I can build this, but result/bin/neovide or result/bin/neovide README.md in my nixpkgs clone simply does nothing (exit code of the program is 0). Am I doing something wrong?

@ck3d
Copy link
Contributor Author

ck3d commented Jun 30, 2022

It you be that you faced issue #168769.

What is the output when you run the command neovide --nofork?

@pmiddend
Copy link
Contributor

pmiddend commented Jun 30, 2022

@ck3d Correct, I'm getting:

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: CreationErrors([OsError("Could not create EGL display object"), OsError("`glXQueryExtensionsString` found no glX extensions")])', src/window/mod.rs:347:10
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Note that I don't run NixOS at all, but rather an Ubuntu 22 with Nix installed.

@ck3d
Copy link
Contributor Author

ck3d commented Jun 30, 2022

The error is the same, OpenGL can not be initialized. Does neovide-0.8 from master branch show the same error?

@pmiddend
Copy link
Contributor

The error is the same, OpenGL can not be initialized. Does neovide-0.8 from master branch show the same error?

Yes, same error. I might not be the best person to review this update then. ;)

@teto
Copy link
Member

teto commented Jul 1, 2022

if the error was preexisting this PR which I think it does, let's merge. @ck3d you've got the permissions go ahead :)

@ck3d
Copy link
Contributor Author

ck3d commented Jul 1, 2022

I don't have merge rights (but I requested them a few days ago), so can you please merge my PR.

@teto teto merged commit dd3a47e into NixOS:master Jul 1, 2022
@kirillrdy
Copy link
Member

this change doesnt build on master here is a fix #179858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: vim 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants