Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neovide: fixup hash #179858

Merged
merged 1 commit into from
Jul 2, 2022
Merged

neovide: fixup hash #179858

merged 1 commit into from
Jul 2, 2022

Conversation

kirillrdy
Copy link
Member

Description of changes

after recent change to nix-prefetch-git 1dfaad7

some inflight PRs checksums dont match anymore

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@kirillrdy kirillrdy requested review from jonringer and teto as code owners July 2, 2022 04:18
@kirillrdy
Copy link
Member Author

cc @ck3d

@kirillrdy kirillrdy mentioned this pull request Jul 2, 2022
Merged
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 2, 2022
ck3d
ck3d approved these changes Jul 2, 2022
View reviewed changes
Copy link
Contributor

@ck3d ck3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the update.

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 2, 2022
@teto
Copy link
Member

teto commented Jul 2, 2022

seems like neovide is in cache and nix-build -A neovide --check works too on master: on which platforms is the build supposed to fail ?

@ck3d
Copy link
Contributor

ck3d commented Jul 2, 2022

You can check the new hashes by invalidating the existing and building neovide.

@teto
Copy link
Member

teto commented Jul 2, 2022

indeed thanks

@teto teto merged commit 2de1b09 into NixOS:master Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ck3d ck3d ck3d approved these changes

@jonringer jonringer Awaiting requested review from jonringer

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirillrdy @teto @ck3d @bobby285271