Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.11] hypnotix: Fix launching with mpv 0.35.0 #203563

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented Nov 29, 2022

Picked from #201328 commit f0c5278.

Fix launching with mpv 0.35.0 (ubuntu 22.04 doesn't have libmpv.so.2)

Description of changes
Traceback (most recent call last):
  File "/nix/store/dlv4a0gbgc7vbcg5jxpy6hkgm97xx7l0-hypnotix-2.9/lib/hypnotix/hypnotix.py", line 25, in <module>
    import mpv
  File "/nix/store/dlv4a0gbgc7vbcg5jxpy6hkgm97xx7l0-hypnotix-2.9/lib/hypnotix/mpv.py", line 526, in <module>
    _handle_func('mpv_detach_destroy',          [],                                         None, errcheck=None)
  File "/nix/store/dlv4a0gbgc7vbcg5jxpy6hkgm97xx7l0-hypnotix-2.9/lib/hypnotix/mpv.py", line 473, in _handle_func
    func = getattr(backend, name)
  File "/nix/store/zdba9frlxj2ba8ca095win3nphsiiqhb-python3-3.10.8/lib/python3.10/ctypes/__init__.py", line 387, in __getattr__
    func = self.__getitem__(name)
  File "/nix/store/zdba9frlxj2ba8ca095win3nphsiiqhb-python3-3.10.8/lib/python3.10/ctypes/__init__.py", line 392, in __getitem__
    func = self._FuncPtr((name_or_ordinal, self))
AttributeError: /nix/store/6wb0c9kkb758j10nakwhnb4k59l0aqsj-mpv-with-scripts-0.35.0/lib/libmpv.so: undefined symbol: mpv_detach_destroy
Things done

See hypnotix issue 254 for more info.

(cherry picked from commit f0c5278)
@ofborg ofborg bot requested a review from dotlambda November 29, 2022 07:06
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 29, 2022
@bobby285271
Copy link
Member Author

bobby285271 commented Nov 29, 2022

Made some noise in linuxmint/hypnotix#254.

For the fix-deprecated-mpv-detach-destroy.patch, I believe when I want to PR to upstream I want to do a full sync with https://github.com/jaseg/python-mpv/blob/main/mpv.py but I am too lazy to know what is changed and when is the good time to do that and mint don't have libmpv.so.2 yet.

@bobby285271 bobby285271 merged commit aab0733 into NixOS:release-22.11 Nov 29, 2022
@bobby285271 bobby285271 deleted the hypnotix-bpo branch November 29, 2022 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant