Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mujs: 1.2.0 -> 1.3.2 #203664

Merged
merged 1 commit into from
Dec 1, 2022
Merged

mujs: 1.2.0 -> 1.3.2 #203664

merged 1 commit into from
Dec 1, 2022

Conversation

LeSuisse
Copy link
Member

Description of changes

Fixes CVE-2022-44789.

https://git.ghostscript.com/?p=mujs.git;a=shortlog;h=refs/tags/1.3.2

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

1 package marked as broken and skipped:
  • gnome-mpv
1 package failed to build:
  • minitube
35 packages built:
  • adl
  • ani-cli
  • anime-downloader
  • anki
  • ankisyncd
  • celluloid
  • curseradio
  • dmlive
  • ff2mpv
  • haruna
  • hydrus
  • hypnotix
  • jellyfin-media-player
  • jellyfin-mpv-shim
  • jftui
  • manga-cli
  • mnemosyne
  • mpc-qt
  • mpv
  • mpv-unwrapped
  • mpvScripts.mpris
  • mpvpaper
  • mujs
  • plex-media-player
  • plex-mpv-shim
  • python310Packages.mpv
  • python39Packages.mpv
  • qimgv
  • radioboat
  • sioyek
  • somafm-cli
  • stremio
  • sublime-music
  • ytfzf
  • zathura

No new failures.

@LeSuisse LeSuisse added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-22.05 labels Nov 29, 2022
@ofborg ofborg bot requested a review from pSub November 29, 2022 21:33
raphaelr
raphaelr reviewed Nov 30, 2022
View reviewed changes
Copy link
Contributor

@raphaelr raphaelr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the nixpkgs-review result on x86_64-linux, even minitube works now. ./result/bin/mujs works.

Maybe reverting commit d592c785c0b2f9fea982ac3fe7b88fdd7c4817fc makes the darwin builders happy?

@LeSuisse
Copy link
Member Author

LeSuisse commented Nov 30, 2022 •
edited
Loading

Updated, thanks for the hint for darwin 👍

Edit: build issue reported upstream ccxvii/mujs#168

@LeSuisse LeSuisse mentioned this pull request Nov 30, 2022
Open
@risicle risicle mentioned this pull request Nov 30, 2022
Merged
13 tasks
@risicle
Copy link
Contributor

risicle commented Nov 30, 2022

Think it's quite a simple patch - #203817

risicle
risicle approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@risicle risicle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review happy, macos 10.15, nixos x86_64 & aarch64. pkgsMusl & pkgsCross.riscv64 variants build.

@risicle risicle merged commit d6274e9 into NixOS:master Dec 1, 2022
@github-actions github-actions bot mentioned this pull request Dec 1, 2022
Merged
1 task
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

Successfully created backport PR #203837 for release-22.11.

@LeSuisse LeSuisse deleted the mujs-1.3.2 branch December 1, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelr raphaelr raphaelr approved these changes

@risicle risicle risicle approved these changes

@pSub pSub Awaiting requested review from pSub

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeSuisse @risicle @raphaelr