Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtk_9: propagate libX11 and libGL on Linux #206935

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

bcdarwin
Copy link
Member

Description of changes

Propagate some libraries which are needed whenever CMake looks for VTK and finds VTK 9.x; see discussion on #178367. It's a bit of a hack but hopefully we can remove vtk_8 soon and then it'll no longer be needed.

@veprbl @wegank

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Dec 19, 2022
@bcdarwin bcdarwin force-pushed the vtk_9-propagate-libs branch from 95156be to 5727443 Compare December 19, 2022 23:16
@bcdarwin bcdarwin requested a review from veprbl December 19, 2022 23:16
@bcdarwin bcdarwin force-pushed the vtk_9-propagate-libs branch from 5727443 to cf339f3 Compare December 19, 2022 23:17
@lheckemann lheckemann merged commit 6919026 into NixOS:master Dec 20, 2022
@bcdarwin bcdarwin deleted the vtk_9-propagate-libs branch December 20, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants