-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openssl] remove run-time dependency of perl due to c_rehash #219323
[openssl] remove run-time dependency of perl due to c_rehash #219323
Conversation
Replaces perl based c_rehash script with shell script wrapping `openssl rehash` with the same functionality. Fixes: NixOS#19965 Supersedes: NixOS#156776, NixOS#83446 Possibly related to: NixOS#157093, NixOS#82924
as discussed here the happy to do this if there are no objections |
Need to add these changes for |
Was just going to ask 😄 Once the final decision is made regarding keeping\removing the withPerl flag I’ll apply the changes there as well |
let's drop withPerl (assuming |
f6fdef7
to
2d7e0f0
Compare
Co-authored-by: Artturi <Artturin@artturin.com>
2d7e0f0
to
b7a5ddb
Compare
@Artturin removed |
Needs to target staging and the commit msg's need to be changed to our style, instructions for both in |
Hey, there's about a month until the 23.05 release and it would be awesome to get this merged before then. Are there any blockers remaining? |
@ofborg build openssl quictls |
Needs to target staging check CONTRIBUTING.md for how to rebase |
oh already said that |
Can't push to this PR |
#226108 kept your authorship in the commits |
@Artturin thanks! I didn’t really have time to address your comment so it’s great to took care of it :) |
Description of changes
Replaces perl based c_rehash script with shell script wrapping
openssl rehash
with the same functionality.
Fixes: #19965
Supersedes: #156776, #83446
Possibly related to: #157093, #82924
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)