Fix the nixpkgs manual, build it on lib changes #219488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it's an attribute set, the lib function location generating code tries to generate locations for each of the characters...
The nixpkgs manual includes documentation for `lib` functions.
ncfavier
requested review from
edolstra,
infinisil,
a team,
Mic92 and
zowoq
as code owners
ofborg
bot
added
10.rebuild-darwin: 0
fricklerhandwerk
approved these changes
Mar 4, 2023
|
Thanks for figuring this out! |
|
Let me merge fast to fix the CI which could confuse people. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#219235 broke the nixpkgs manual because it introduced
lib.strings.asciiTable, an attribute set, and the code for generating lib function locations naively recurses into attribute sets to determine what subsets we have. See also #116472 (comment)This wasn't detected because we don't build the nixpkgs manual when
libchanges. This PR addresses that, and hidesasciiTablefor now (I don't think it should be exposed anyway).The workflow change won't affect this PR but I can confirm it builds locally.