Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gst_all_1.{vaapi,gst-editing-services}: support cross compilation #225664

Merged
merged 2 commits into from
Apr 15, 2023

Conversation

uninsane
Copy link
Contributor

@uninsane uninsane commented Apr 11, 2023

Description of changes

with this changeset all packages under the gst_all_1 (gstreamer) namespace are cross-compilable, except the unfree ones whose upstream distributes only precompiled .so objects (i.e. gst_all_1.{icamerasrc,viperfx}).

Things done
  • Built on platform(s)
    • x86_64-linux (via native gst_all_1.<xyz>, and cross-compiled pkgsCross.aarch64-multiplatform.gst_all_1.<xyz>
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
    - invoked {qemu-aarch64,} ges-editing-services/bin/ges-launch-1.0 --help
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Apr 11, 2023
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look sensible to me and builds for me native x86_64-linux and cross (with #225977) to aarch64-linux. There seems to be no regressions for dependent packages (the 1 failure below is also reproducible on master)


Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:
  • hqplayerd
62 packages built:
  • anki
  • anki.dist
  • anki.doc
  • anki.man
  • beamerpresenter
  • beamerpresenter-poppler
  • calibre
  • dino
  • fractal
  • gnome-network-displays
  • gnome.rygel
  • gnome.rygel.dev
  • gst_all_1.gst-editing-services
  • gst_all_1.gst-editing-services.dev
  • gst_all_1.gst-vaapi
  • gst_all_1.gst-vaapi.dev
  • hydrus
  • hydrus.doc
  • jami
  • khoj
  • khoj.dist
  • maestral-gui
  • maestral-gui.dist
  • mapmap
  • mediaelch-qt6
  • mnemosyne
  • mnemosyne.dist
  • nanovna-saver
  • nanovna-saver.dist
  • olive-editor
  • picard
  • picard.dist
  • pitivi
  • python310Packages.pyqt6
  • python310Packages.pyqt6-charts
  • python310Packages.pyqt6-charts.dist
  • python310Packages.pyqt6-webengine
  • python310Packages.pyqt6-webengine.dev
  • python310Packages.pyqt6-webengine.dist
  • python310Packages.pyqt6.dev
  • python310Packages.pyqt6.dist
  • python311Packages.pyqt6
  • python311Packages.pyqt6-charts
  • python311Packages.pyqt6-charts.dist
  • python311Packages.pyqt6-webengine
  • python311Packages.pyqt6-webengine.dev
  • python311Packages.pyqt6-webengine.dist
  • python311Packages.pyqt6.dev
  • python311Packages.pyqt6.dist
  • qmmp
  • qt6.full
  • qt6.qt3d
  • qt6.qt3d.dev
  • qt6.qtmultimedia
  • qt6.qtmultimedia.dev
  • qt6.qtspeech
  • qt6.qtspeech.dev
  • qutebrowser-qt6
  • qutebrowser-qt6.dist
  • retext
  • retext.dist
  • stellarium

python3 is used both during the build process (nativeBuildInputs)
and #include'd/linked to by ges-formatter.c (buildInputs)
@Artturin Artturin force-pushed the pr/sane/cross-gstreamer branch from 5b9d2d8 to ceb4451 Compare April 15, 2023 16:11
@Artturin Artturin changed the base branch from staging to master April 15, 2023 16:11
@Artturin Artturin merged commit dd8117d into NixOS:master Apr 15, 2023
@uninsane uninsane deleted the pr/sane/cross-gstreamer branch April 15, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants