Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: remove run-time dependency of perl due to c_rehash #226108

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

Artturin
Copy link
Member

@Artturin Artturin commented Apr 14, 2023

Changes by @adrian-gierakowski
Replaces perl based c_rehash script with shell script wrapping openssl rehash
with the same functionality.

Fixes: #19965
Supersedes: #156776, #83446 #219323
Possibly related to: #157093, #82924

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Replaces perl based c_rehash script with shell script wrapping `openssl rehash`
with the same functionality.

Fixes: NixOS#19965
Supersedes: NixOS#156776, NixOS#83446
Possibly related to: NixOS#157093, NixOS#82924
@Izorkin
Copy link
Contributor

Izorkin commented Apr 14, 2023

Is it possible to make these changes in quictls?

@thomasjm
Copy link
Contributor

@Izorkin that appears to have been done already in the second commit.

@Izorkin
Copy link
Contributor

Izorkin commented Apr 14, 2023

@Izorkin that appears to have been done already in the second commit.

Right, I wasn't paying attention :)

@gdamjan
Copy link
Contributor

gdamjan commented Apr 14, 2023

built the 2 commits on top of master (x86_64-linux):

image

nice work

@Artturin Artturin marked this pull request as ready for review April 14, 2023 13:43
@adrian-gierakowski
Copy link
Contributor

built the 2 commits on top of master (x86_64-linux):

image

nice work

@gdamjan what’s this TUI you have there for inspecting deps?

@gdamjan
Copy link
Contributor

gdamjan commented Apr 14, 2023

@gdamjan what’s this TUI you have there for inspecting deps?

:)
it's nix-tree
https://github.com/utdemir/nix-tree

@Artturin
Copy link
Member Author

Built openssl and quictls on aarch64-darwin

@Artturin Artturin merged commit bf0d269 into NixOS:staging Apr 14, 2023
@Artturin Artturin deleted the opensslperldep branch April 14, 2023 18:40
@adrian-gierakowski
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants