Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdecor: move headers out to "dev" output #226402

Merged
merged 1 commit into from
Apr 16, 2023
Merged

libdecor: move headers out to "dev" output #226402

merged 1 commit into from
Apr 16, 2023

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Apr 16, 2023 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from Artturin April 16, 2023 08:16
@vcunat vcunat added the 6.topic: closure size The final size of a derivation, including its dependencies label Apr 16, 2023
@Artturin
Copy link
Member

SDL2 builds and finds libdecor

@Artturin Artturin merged commit ea788f0 into NixOS:staging Apr 16, 2023
@trofi trofi deleted the libdecor-add-dev-output branch April 16, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Artturin Artturin Awaiting requested review from Artturin

Assignees
No one assigned
Labels
6.topic: closure size The final size of a derivation, including its dependencies 10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trofi @Artturin @vcunat