Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnuplot_qt: fix build failure #229479

Closed
wants to merge 1 commit into from

Conversation

wentasah
Copy link
Contributor

@wentasah wentasah commented May 2, 2023

Recently, wrapQtAppsHook was switched from shell to binary wrapper (#225881). The binary wrapper does not support --run, which is used by gnuplot. When gnuplot is built with Qt terminal, it "inherits" the wrong wrapping function from Qt. In this commit we replace the wrapping function back to the one generating a shell wrapper.

Fixes #229425.

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Recently, wrapQtAppsHook was switched from shell to binary wrapper.
The binary wrapper does not support --run, which is used by gnuplot.
When gnuplot is built with Qt terminal, it "inherits" the wrong
wrapping function from Qt. In this commit we replace the wrapping
function back to the one generating a shell wrapper.

Fixes NixOS#229425.
@wentasah wentasah requested a review from lovek323 May 2, 2023 14:58
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 2, 2023
@wentasah
Copy link
Contributor Author

wentasah commented May 4, 2023

Closing in favor of #229154.

@wentasah wentasah closed this May 4, 2023
@wentasah wentasah deleted the gnuplot-fix-wrapper branch October 4, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: gnuplot_qt
2 participants