Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nerdfonts: 3.0.0 -> 3.0.1 #231749

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

msfjarvis
Copy link
Contributor

@msfjarvis msfjarvis commented May 13, 2023

Description of changes

https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.0.1

Also switches over to the newly introduced tar.xz archives since they're significantly smaller than the ZIP files and speed up building of this package considerably.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@andrevmatos andrevmatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working fine here

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/944

@msfjarvis
Copy link
Contributor Author

Rebased on current master

Also switch to XZ archives since they're significantly smaller
@SuperSandro2000 SuperSandro2000 merged commit 2ecf987 into NixOS:master May 16, 2023
@msfjarvis msfjarvis deleted the hs/nerdfonts-3.0.1 branch May 16, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants